Re: [pbs-devel] [PATCH proxmox{, -backup} v5 00/11] fix #5379: introduce default auth realm option

From: Lukas Wagner <l.wagner@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>,
	Christoph Heiss <c.heiss@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox{, -backup} v5 00/11] fix #5379: introduce default auth realm option
Date: Fri, 4 Apr 2025 15:34:14 +0200	[thread overview]
Message-ID: <121326f3-bbdf-46b7-9a86-cc4a9225ea91@proxmox.com> (raw)
In-Reply-To: <20250321134541.1106117-1-c.heiss@proxmox.com>

On  2025-03-21 14:45, Christoph Heiss wrote:
> Fixes #5379 [0].
> 
> First, it adds an updatable `default` field to all existing editable
> realms. Then it converts the PAM and PBS built-in realms to proper
> realms, instead of being hard-coded in-between somewhere. 
> In turns this enables editing of these realms, allowing setting whether
> these realms should be the default for login or not.
> 
> For patch #3 onwards, proxmox-backup needs patches #1 & #2 applied to
> pbs-api-types and a bump thereof.
> 
> The proxmox-widget-toolkit parts have already been applied [1] and
> proxmox-backup also pulls in the required version (introduced with pwt
> 4.3.1, proxmox-backup pulls in >= 4.3.3).
> 
> W.r.t. the inconsistency as discovered/discussed in [2], the (current)
> behaviour is not changed in this series. Since both PVE and PBS use the
> same realm login dialog from proxmox-widget-toolkit, I'd rather fix it
> separately -- to avoid blocking this series on a completely separate
> issue, which might still need some discussing.
> 
> [0] https://bugzilla.proxmox.com/show_bug.cgi?id=5379
> [1] https://lore.proxmox.com/pbs-devel/d56c6e30-61d7-452b-afaa-5215d8538b4e@proxmox.com/#t
> [2] https://lists.proxmox.com/pipermail/pbs-devel/2024-August/010429.html
> 

Gave this a quick test on the lastest master branches. Setting a default realm
works as expected. The statefulness of the login window even if a default
is configured [your 2] still feels odd to me, but as you have said, this is consistent with
PVE and can be changed in a separate series, if we decide that we want that.

Only skimmed over the code since I already did a review of v1;
looks good to me so far. The nits that Shannon raised can be fixed in v6 or in a followup.

Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>
Tested-by: Lukas Wagner <l.wagner@proxmox.com>

-- 
- Lukas

_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel