From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Cc: Wolfgang Bumiller <w.bumiller@proxmox.com>
Subject: [pbs-devel] applied-series: [PATCH proxmox-backup 0/6] tfa fixups
Date: Wed, 13 Jan 2021 17:05:27 +0100 [thread overview]
Message-ID: <11c952a6-616a-6bf9-0251-9d1dc94bac20@proxmox.com> (raw)
In-Reply-To: <20210113110654.17425-1-d.csapak@proxmox.com>
On 13.01.21 12:06, Dominik Csapak wrote:
> fixed some of the more weird spacing/style issues i saw
>
> there are still some issues, but maybe someone else can look at it:
>
> * there is no gui for initial webauthn setup (which is mandatory)
> * The text 'Copy Secret Value' is weird, but i could not come up with
> something better for now
> * on login, the text should not be 'OTP' for recovery keys, it should be
> distinct, else it is very confusing
> * the spacing on the login windows and deletion confirm window is still
> wrong
> * the deletion confirm window has the title 'Confirm Password', but as
> root@pam, there is no password field (better only "Conifrm"?)
it is also weirdly formatted..
> we maybe can reuse our 'Safe Destroy Window' here?
> * when i enter a wrong password, the error message is
>
> AUTH_ERR (7)
>
> which is not informational, and not consistent with our login.
> * Some edit/add windows can be refactored using the Edit Window,
> currently the functionality is duplicated across them
> (addWebauthn, addTotp, etc.)
> * The warning that there are only few recovery codes left has too many
> warning icons (one should be enough)
> * Sometimes i ran into an issue, where, if i have the recovery login
> window open for too long, the code is not accepted. It was not very
> clear to me if i can reuse that code again (i could) but that seems
> to be bad ux, since normally a recovery code is not something i have
> on hand, and it'll take a while until i found one.
>
>
> Dominik Csapak (6):
> ui: LoginView: remove not used viewModel
> ui: config/TfaView: disable Remove button by default
> ui: window/AddTfaRecovery: rewrite to a Proxmox.window.Edit
> ui: window/AddTfaRecovery: fix style of TfaRecoveryShow window
> ui: window/AddTotp: fix spacing styling of form fields
> ui: window/{AddWebauthn,TfaEdit}: fix spacing/border of the windows
>
> www/LoginView.js | 8 ---
> www/config/TfaView.js | 1 +
> www/window/AddTfaRecovery.js | 136 ++++++++++++-----------------------
> www/window/AddTotp.js | 81 ++++++++++-----------
> www/window/AddWebauthn.js | 2 +-
> www/window/TfaEdit.js | 1 -
> 6 files changed, 86 insertions(+), 143 deletions(-)
>
applied series, much thanks for those initial fixes!
@Wolfgang, maybe you can also tackle a few of those when sending patches for adding
the initial setup part - after all the JS/gui part got pushed without any real review
by you ;P
prev parent reply other threads:[~2021-01-13 16:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-13 11:06 [pbs-devel] " Dominik Csapak
2021-01-13 11:06 ` [pbs-devel] [PATCH proxmox-backup 1/6] ui: LoginView: remove not used viewModel Dominik Csapak
2021-01-13 11:06 ` [pbs-devel] [PATCH proxmox-backup 2/6] ui: config/TfaView: disable Remove button by default Dominik Csapak
2021-01-13 11:06 ` [pbs-devel] [PATCH proxmox-backup 3/6] ui: window/AddTfaRecovery: rewrite to a Proxmox.window.Edit Dominik Csapak
2021-01-13 11:06 ` [pbs-devel] [PATCH proxmox-backup 4/6] ui: window/AddTfaRecovery: fix style of TfaRecoveryShow window Dominik Csapak
2021-01-13 11:06 ` [pbs-devel] [PATCH proxmox-backup 5/6] ui: window/AddTotp: fix spacing styling of form fields Dominik Csapak
2021-01-13 11:06 ` [pbs-devel] [PATCH proxmox-backup 6/6] ui: window/{AddWebauthn, TfaEdit}: fix spacing/border of the windows Dominik Csapak
2021-01-13 11:12 ` [pbs-devel] [PATCH proxmox-backup 0/6] tfa fixups Dominik Csapak
2021-01-13 16:05 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11c952a6-616a-6bf9-0251-9d1dc94bac20@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=w.bumiller@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox