From: Dietmar Maurer <dietmar@proxmox.com>
To: Wolfgang Bumiller <w.bumiller@proxmox.com>
Cc: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH backup] client: use build_authority in build_uri
Date: Thu, 6 May 2021 09:34:03 +0200 (CEST) [thread overview]
Message-ID: <1181206651.274.1620286443593@webmail.proxmox.com> (raw)
> On 05/06/2021 9:14 AM Wolfgang Bumiller <w.bumiller@proxmox.com> wrote:
>
>
> On Thu, May 06, 2021 at 09:01:46AM +0200, Dietmar Maurer wrote:
> > In general a good idea, but we now merge code
> > from two independent http client implementation (making them
> > dependent)?
>
> I mean... it's called "tools::http"... as in "http utilities", which
> IMO does not really sound like "this is an independent http client,
> which must not be reused"... ;-)
What naming do you suggest instead?
> And it's a rather thin layer around hyper (the *actual* client...) to
> add proxy support which, too, is something that we may at some point
> want to reuse without the rest of `SimpleHttp`, no?
I am not sure if it is worth to reuse that for that backup client. We simply
do not need proxy support there.
next reply other threads:[~2021-05-06 7:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-06 7:34 Dietmar Maurer [this message]
2021-05-06 7:43 ` Wolfgang Bumiller
-- strict thread matches above, loose matches on Subject: below --
2021-05-06 7:01 Dietmar Maurer
2021-05-06 7:14 ` Wolfgang Bumiller
2021-05-06 6:55 Wolfgang Bumiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1181206651.274.1620286443593@webmail.proxmox.com \
--to=dietmar@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=w.bumiller@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox