From: Mira Limbeck <m.limbeck@proxmox.com>
To: Wolfgang Bumiller <w.bumiller@proxmox.com>,
Thomas Lamprecht <t.lamprecht@proxmox.com>
Cc: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-http] http: fix proxy authorization header to include type
Date: Fri, 22 Jul 2022 11:50:43 +0200 [thread overview]
Message-ID: <1165df38-515e-5ace-9234-52c3cf2dc3af@proxmox.com> (raw)
In-Reply-To: <20220721114616.f74gqbo44xlo3pro@casey.proxmox.com>
On 7/21/22 13:46, Wolfgang Bumiller wrote:
> On Thu, Jul 21, 2022 at 01:32:32PM +0200, Thomas Lamprecht wrote:
>> Am 20/07/2022 um 16:20 schrieb Mira Limbeck:
>>> and encode the username:password string as base64 [0]. This fixes the
>>> error 407 issue when using proxy authentication [1].
>> does this break setups that configured "Basic base64-encoded-pw" themselves though,
>> or was that never possible (e.g., due to schema not allowing that)?
> That would break other things. Eg. `ProxyConfig;:to_proxy_string` uses
> it to build "http://<authorization>@<host>" strings, so the "Basic "
> prefix and base64 encoding would break those.
>
> However, we also build such headers in src/client/simple.rs which should
> will need the same change I suppose?
Do we want to make the authentication scheme, here `Basic`, configurable?
prev parent reply other threads:[~2022-07-22 9:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-20 14:20 Mira Limbeck
2022-07-21 10:56 ` [pbs-devel] applied: " Wolfgang Bumiller
2022-07-21 11:32 ` [pbs-devel] " Thomas Lamprecht
2022-07-21 11:46 ` Wolfgang Bumiller
2022-07-22 9:50 ` Mira Limbeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1165df38-515e-5ace-9234-52c3cf2dc3af@proxmox.com \
--to=m.limbeck@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
--cc=w.bumiller@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox