From: Dietmar Maurer <dietmar@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>,
Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Wolfgang Bumiller <w.bumiller@proxmox.com>
Subject: Re: [pbs-devel] applied: [PATCH proxmox-backup v2 1/2] pbs-config: add 'create_mocked_lock' helper
Date: Tue, 7 Sep 2021 10:03:14 +0200 (CEST) [thread overview]
Message-ID: <1118562782.2887.1631001794227@webmail.proxmox.com> (raw)
> On 9/7/21 09:49, Dietmar Maurer wrote:
> > I really do not like this solution :-(
> >
>
> was the trait approach better ?
>
no, that was worse
> since the only remaining way i can can currently think of is to
> workaround the locks everywhere in src/tape/*.rs
I am also out of ideas ...
At least the tests works again.
next reply other threads:[~2021-09-07 8:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-07 8:03 Dietmar Maurer [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-09-07 7:49 Dietmar Maurer
2021-09-07 8:01 ` Dominik Csapak
2021-09-06 15:00 [pbs-devel] " Dominik Csapak
2021-09-07 7:05 ` [pbs-devel] applied: " Wolfgang Bumiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1118562782.2887.1631001794227@webmail.proxmox.com \
--to=dietmar@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=w.bumiller@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox