public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dietmar Maurer <dietmar@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>,
	 Thomas Lamprecht <t.lamprecht@proxmox.com>,
	Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pbs-devel] [RFC PATCH proxmox-backup 0/5] add 'protected' setting for snapshots
Date: Thu, 2 Sep 2021 08:45:57 +0200 (CEST)	[thread overview]
Message-ID: <1118236361.1959.1630565157734@webmail.proxmox.com> (raw)

> > * would we want to protect also against manual removal ? or
> >  'remove-vanished' on sync?
> 
> Would make sense as long as we allow to "unprotect" it, that's how we do it for guests
> in PVE too. IMO it's weird/unexpected to mark it protected and allow some API mechanisms
> to still remove it.

I would not consider the protected flag for syncs, i.e:
- do not sync the protected flag itself
- remove vanished backups even with protected flag set (to be in sync with source)




             reply	other threads:[~2021-09-02  6:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-02  6:45 Dietmar Maurer [this message]
2021-09-02  6:48 ` Thomas Lamprecht
  -- strict thread matches above, loose matches on Subject: below --
2021-09-02  7:05 Dietmar Maurer
2021-09-01  8:25 Dominik Csapak
2021-09-02  6:25 ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1118236361.1959.1630565157734@webmail.proxmox.com \
    --to=dietmar@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal