public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dietmar Maurer <dietmar@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>,
	 Hannes Laimer <h.laimer@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup 0/2] proxy: scheduling cleanup
Date: Thu, 29 Oct 2020 12:21:46 +0100 (CET)	[thread overview]
Message-ID: <1107674365.366.1603970506611@webmail.proxmox.com> (raw)
In-Reply-To: <20201029103749.109210-1-h.laimer@proxmox.com>

Those patches are based on outdated code - please can you rebase them?

> On 10/29/2020 11:37 AM Hannes Laimer <h.laimer@proxmox.com> wrote:
> 
>  
> Logic for gc and logrotate was not moved, could (should?) also be moved later.
> 
>  * moved logic for prune out of proxy
>  * extract commonly used logic for scheduling into new function
> 
> 
> Hannes Laimer (2):
>   proxy: move prune logic into new file
>   proxy: extract commonly used logic for scheduling into new function
> 
>  src/bin/proxmox-backup-proxy.rs | 245 ++++++++------------------------
>  src/server.rs                   |   3 +
>  src/server/prune_job.rs         |  91 ++++++++++++
>  3 files changed, 151 insertions(+), 188 deletions(-)
>  create mode 100644 src/server/prune_job.rs
> 
> -- 
> 2.20.1
> 
> 
> 
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel




      parent reply	other threads:[~2020-10-29 11:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-29 10:37 Hannes Laimer
2020-10-29 10:37 ` [pbs-devel] [PATCH proxmox-backup 1/2] proxy: move prune logic into new file Hannes Laimer
2020-10-29 10:37 ` [pbs-devel] [PATCH proxmox-backup 2/2] proxy: extract commonly used logic for scheduling into new function Hannes Laimer
2020-10-29 11:21 ` Dietmar Maurer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1107674365.366.1603970506611@webmail.proxmox.com \
    --to=dietmar@proxmox.com \
    --cc=h.laimer@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal