From: Dietmar Maurer <dietmar@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Wolfgang Bumiller <w.bumiller@proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pbs-devel] applied: [PATCH proxmox-backup v2 1/2] pbs-config: add 'create_mocked_lock' helper
Date: Tue, 7 Sep 2021 09:49:37 +0200 (CEST) [thread overview]
Message-ID: <1069826666.2878.1631000977842@webmail.proxmox.com> (raw)
I really do not like this solution :-(
> On 09/07/2021 9:05 AM Wolfgang Bumiller <w.bumiller@proxmox.com> wrote:
>
>
> applied both patches
>
> On Mon, Sep 06, 2021 at 05:00:25PM +0200, Dominik Csapak wrote:
> > by making the field an option and making it None in the mocked case
> > this function is only intended for testing and hidden from the docs
> >
> > Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> > ---
> > changes from v1:
> > * mark function unsafe, so that it is even more clear that this is not
> > intended for 'normal' code
> > pbs-config/src/lib.rs | 10 ++++++++--
> > 1 file changed, 8 insertions(+), 2 deletions(-)
> >
> > diff --git a/pbs-config/src/lib.rs b/pbs-config/src/lib.rs
> > index 29811164..bd5430a3 100644
> > --- a/pbs-config/src/lib.rs
> > +++ b/pbs-config/src/lib.rs
> > @@ -18,7 +18,13 @@ pub fn backup_group() -> Result<nix::unistd::Group, Error> {
> > pbs_tools::sys::query_group(BACKUP_GROUP_NAME)?
> > .ok_or_else(|| format_err!("Unable to lookup '{}' group.", BACKUP_GROUP_NAME))
> > }
> > -pub struct BackupLockGuard(std::fs::File);
> > +pub struct BackupLockGuard(Option<std::fs::File>);
> > +
> > +#[doc(hidden)]
> > +/// Note: do not use for production code, this is only intended for tests
> > +pub unsafe fn create_mocked_lock() -> BackupLockGuard {
> > + BackupLockGuard(None)
> > +}
> >
> > /// Open or create a lock file owned by user "backup" and lock it.
> > ///
> > @@ -41,7 +47,7 @@ pub fn open_backup_lockfile<P: AsRef<std::path::Path>>(
> > let timeout = timeout.unwrap_or(std::time::Duration::new(10, 0));
> >
> > let file = proxmox::tools::fs::open_file_locked(&path, timeout, exclusive, options)?;
> > - Ok(BackupLockGuard(file))
> > + Ok(BackupLockGuard(Some(file)))
> > }
> >
> > /// Atomically write data to file owned by "root:backup" with permission "0640"
> > --
> > 2.30.2
>
>
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next reply other threads:[~2021-09-07 7:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-07 7:49 Dietmar Maurer [this message]
2021-09-07 8:01 ` Dominik Csapak
-- strict thread matches above, loose matches on Subject: below --
2021-09-07 8:03 Dietmar Maurer
2021-09-06 15:00 [pbs-devel] " Dominik Csapak
2021-09-07 7:05 ` [pbs-devel] applied: " Wolfgang Bumiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1069826666.2878.1631000977842@webmail.proxmox.com \
--to=dietmar@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=w.bumiller@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox