From: Christian Ebner <c.ebner@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>, pbs-devel@lists.proxmox.com
Subject: Re: applied: [PATCH proxmox-backup v8 00/17] partially fix #6563: add s3 counter for statistics and notifications
Date: Fri, 10 Apr 2026 07:56:08 +0200 [thread overview]
Message-ID: <0ea651d8-a4a7-4232-91aa-82c401b0219d@proxmox.com> (raw)
In-Reply-To: <177578214248.2697034.10511094955518196902.b4-ty@proxmox.com>
On 4/10/26 2:48 AM, Thomas Lamprecht wrote:
> On Thu, 02 Apr 2026 12:53:16 +0200, Christian Ebner wrote:
>> This patch series implements request and traffic counters for the s3
>> client, being shared as atomic counters via shared memory and mmapping
>> across all s3-client instances.
>>
>> The shared counters are instantiated on demand for individual
>> datastores with s3 backend on s3 client instantiation and stored as
>> part of the datastore implementation by loading the mmapped file on
>> datastore creation, being cached for further access. Counter threshold
>> values can be defined in the datastore options, allowing to send
>> notifications via the notification system if counters exceeded the set
>> threshold values. Further, a per-datastore schedule can be configured
>> to reset the counters with given interval.
>>
>> [...]
>
> Applied, with a few follow-ups that should address your own and Dominik
> findings, thanks!
Huge thanks for the code cleanups! Especially the changes with respect
to the requests threshold callback make the code way better!
prev parent reply other threads:[~2026-04-10 5:55 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-02 10:53 Christian Ebner
2026-04-02 10:53 ` [PATCH proxmox-backup v8 01/17] api: s3: add endpoint to reset s3 request counters Christian Ebner
2026-04-02 10:53 ` [PATCH proxmox-backup v8 02/17] bin: s3: expose request counter reset method as cli command Christian Ebner
2026-04-02 10:53 ` [PATCH proxmox-backup v8 03/17] ui: datastore summary: move store to be part of summary panel Christian Ebner
2026-04-02 10:53 ` [PATCH proxmox-backup v8 04/17] ui: expose s3 request counter statistics in the datastore summary Christian Ebner
2026-04-09 8:21 ` Dominik Csapak
2026-04-09 8:28 ` Christian Ebner
2026-04-02 10:53 ` [PATCH proxmox-backup v8 05/17] metrics: collect s3 datastore statistics as rrd metrics Christian Ebner
2026-04-02 10:53 ` [PATCH proxmox-backup v8 06/17] api: admin: expose s3 statistics in datastore rrd data Christian Ebner
2026-04-02 10:53 ` [PATCH proxmox-backup v8 07/17] partially fix #6563: ui: expose s3 rrd charts in datastore summary Christian Ebner
2026-04-02 10:53 ` [PATCH proxmox-backup v8 08/17] datastore: refactor datastore lookup parameters into dedicated type Christian Ebner
2026-04-02 10:53 ` [PATCH proxmox-backup v8 09/17] api: config: update notification thresholds for config and counters Christian Ebner
2026-04-02 10:53 ` [PATCH proxmox-backup v8 10/17] ui: add notification thresholds edit window Christian Ebner
2026-04-02 10:53 ` [PATCH proxmox-backup v8 11/17] notification: define templates and template data for thresholds Christian Ebner
2026-04-02 10:53 ` [PATCH proxmox-backup v8 12/17] datastore: add thresholds notification callback on datastore lookup Christian Ebner
2026-04-02 10:53 ` [PATCH proxmox-backup v8 13/17] api/ui: notifications: add 'thresholds' as notification type value Christian Ebner
2026-04-02 10:53 ` [PATCH proxmox-backup v8 14/17] api: config: allow counter reset schedule editing Christian Ebner
2026-04-02 10:53 ` [PATCH proxmox-backup v8 15/17] ui: expose counter reset schedule edit window Christian Ebner
2026-04-02 10:53 ` [PATCH proxmox-backup v8 16/17] bin: proxy: periodically schedule counter reset task Christian Ebner
2026-04-02 10:53 ` [PATCH proxmox-backup v8 17/17] ui: add task description for scheduled counter reset Christian Ebner
2026-04-09 9:34 ` [PATCH proxmox-backup v8 00/17] partially fix #6563: add s3 counter for statistics and notifications Dominik Csapak
2026-04-09 9:39 ` Christian Ebner
2026-04-10 0:49 ` applied: " Thomas Lamprecht
2026-04-10 5:56 ` Christian Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ea651d8-a4a7-4232-91aa-82c401b0219d@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox