public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>, Oguz Bektas <o.bektas@proxmox.com>
Subject: [pbs-devel] applied:  [PATCH v2 backup] zsh: fix completions
Date: Fri, 3 Sep 2021 10:53:28 +0200	[thread overview]
Message-ID: <0ce84250-3505-59a0-c0a3-c13129085f07@proxmox.com> (raw)
In-Reply-To: <20210902114823.1437899-1-o.bektas@proxmox.com>

On 02.09.21 13:48, Oguz Bektas wrote:
> seems like there was a typo in these from the beginning.

all well, but as it worked just fine here in zsh it would be good to also
state what effects using the spelling variables had.

At least in my setup I could tab-complete also things like:
"proxmox-backup-manager network update ens18"

(I checked with execsnoop to see what command got executed, was the
"faulty" one before this patch)

maybe some smart-feature from my setup though

> 
> also fixes the wrong function name for proxmox-file-restore completion
> 
> Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
> ---
> v1->v2:
> * fix the other typo i made in proxmox-backup-debug...
> 
> 
>  zsh-completions/_pmt                    | 2 +-
>  zsh-completions/_pmtx                   | 2 +-
>  zsh-completions/_proxmox-backup-client  | 2 +-
>  zsh-completions/_proxmox-backup-debug   | 2 +-
>  zsh-completions/_proxmox-backup-manager | 2 +-
>  zsh-completions/_proxmox-file-restore   | 6 +++---
>  zsh-completions/_proxmox-tape           | 2 +-
>  zsh-completions/_pxar                   | 2 +-
>  8 files changed, 10 insertions(+), 10 deletions(-)
> 
>

applied, thanks!




      reply	other threads:[~2021-09-03  8:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-02 11:48 [pbs-devel] " Oguz Bektas
2021-09-03  8:53 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0ce84250-3505-59a0-c0a3-c13129085f07@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=o.bektas@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal