public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: David Riley <d.riley@proxmox.com>, pbs-devel@lists.proxmox.com
Subject: Re: [PATCH proxmox-backup] fix #7412: ui: dashboard: persist datastore usage column state
Date: Wed, 25 Mar 2026 17:36:59 +0100	[thread overview]
Message-ID: <0c0c7dbc-cc07-4f67-b879-851410f0d0be@proxmox.com> (raw)
In-Reply-To: <20260324093425.38594-1-d.riley@proxmox.com>

Thanks for the patch!

Only one nit inline, which may however be considered when applying.

Tested state is maintained on page refresh and survives a logout/login.

On 3/24/26 10:34 AM, David Riley wrote:
> Store the state of the columns for the Datastore Usage Dashboard.
> Ensures the column configuration is maintained across
> page reloads and navigations instead of resetting to the default view.
> 
> Signed-off-by: David Riley <d.riley@proxmox.com>
> ---

Fixes: https://bugzilla.proxmox.com/show_bug.cgi?id=7412
Reviewed-by: Christian Ebner <c.ebner@proxmox.com>
Tested-by: Christian Ebner <c.ebner@proxmox.com>


>   www/dashboard/DataStoreStatistics.js | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/www/dashboard/DataStoreStatistics.js b/www/dashboard/DataStoreStatistics.js
> index c210d24d..7a33f49d 100644
> --- a/www/dashboard/DataStoreStatistics.js
> +++ b/www/dashboard/DataStoreStatistics.js
> @@ -55,6 +55,8 @@ Ext.define('PBS.DatastoreStatistics', {
>   
>       title: gettext('Datastore Usage'),
>       disableSelection: true,
> +    stateful: true,
> +    stateId: 'dashboard-grid-datastore-usage',

nit: other occurrences of `stateId` for grids in the PBS code base seem 
to typically follow the form `grid-{component-name}`, so this should be 
`grid-datastore-statistics`.

>   
>       emptyText: gettext('No Data'),
>   





  reply	other threads:[~2026-03-25 16:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-24  9:34 David Riley
2026-03-25 16:36 ` Christian Ebner [this message]
2026-03-26 13:28 ` superseded: " David Riley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0c0c7dbc-cc07-4f67-b879-851410f0d0be@proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=d.riley@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal