From: Gabriel Goller <g.goller@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Christian Ebner <c.ebner@proxmox.com>
Subject: Re: [pbs-devel] [PATCH v3 proxmox-backup] ui: warn of missing gc-schedule, prune/verify jobs
Date: Wed, 6 Dec 2023 14:37:23 +0100 [thread overview]
Message-ID: <0bbf284e-0f77-4ca1-aefc-dc31b3932f67@proxmox.com> (raw)
In-Reply-To: <20231206113101.139743-1-c.ebner@proxmox.com>
LGTM!
Tested-by: Gabriel Goller <g.goller@proxmox.com>
Reviewed-by: Gabriel Goller <g.goller@proxmox.com>
On 12/6/23 12:31, Christian Ebner wrote:
> Warn about a missing garbage collection schedule, prune job or verify
> job configurations in the datastore's summary panel.
>
> Show the number of prune/verify job configurations, if there are jobs
> configured.
>
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---
> changes since version 2:
> - move message string initialization to controllers `init` function
>
> changes since version 1:
> - add check mark icon for configured jobs/schedule
> - add question mark icon for unknown configuration state
> - fix typo in garbage collection variable name
> - add missing trailing commas found by pve-eslint
> - refactor message initialization to allow to use format helper
> functions
> www/datastore/Summary.js | 96 ++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 96 insertions(+)
>
> [..]
next prev parent reply other threads:[~2023-12-06 13:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-06 11:31 Christian Ebner
2023-12-06 13:37 ` Gabriel Goller [this message]
2023-12-06 14:09 ` Fabian Grünbichler
2023-12-06 14:43 ` Christian Ebner
2023-12-11 9:09 ` Thomas Lamprecht
2023-12-11 9:44 ` Christian Ebner
2023-12-11 10:43 ` Thomas Lamprecht
2023-12-11 10:59 ` Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0bbf284e-0f77-4ca1-aefc-dc31b3932f67@proxmox.com \
--to=g.goller@proxmox.com \
--cc=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox