From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: Re: [pbs-devel] [PATCH xtermjs] fix console window title for rust template
Date: Wed, 11 Nov 2020 13:07:06 +0100 [thread overview]
Message-ID: <0bba9e97-55ff-6b0a-e69c-862af84d40b6@proxmox.com> (raw)
In-Reply-To: <b8ea1493-dd51-8fbd-f062-59b5a58181d4@proxmox.com>
On 11/11/20 12:22 PM, Thomas Lamprecht wrote:
> On 11.11.20 11:08, Aaron Lauterer wrote:
>> The nodename was missing from the title because the variable name is
>> capitalized.
>>
>> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
>> ---
>> src/www/index.html.hbs.in | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/www/index.html.hbs.in b/src/www/index.html.hbs.in
>> index ecbea1b..0dba066 100644
>> --- a/src/www/index.html.hbs.in
>> +++ b/src/www/index.html.hbs.in
>> @@ -1,7 +1,7 @@
>> <!doctype html>
>> <html>
>> <head>
>> - <title>{{ nodename }} - Proxmox Console</title>
>> + <title>{{ NodeName }} - Proxmox Console</title>
>> <link rel="stylesheet" href="/xtermjs/xterm.css?version=@VERSION@" />
>> <link rel="stylesheet" href="/xtermjs/style.css?version=@VERSION@" />
>> <script src="/xtermjs/xterm.js?version=@VERSION@" ></script>
>>
>
> this does not apply here?
>
>
just fyi, it does here...
master is on
commit b0b1ab07886b801c1f40861e73579fa0f93ca3a0 (origin/master)
Author: Thomas Lamprecht <t.lamprecht@proxmox.com>
Date: Fri Aug 28 13:51:48 2020 +0200
bump version to 4.7.0-2
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
next prev parent reply other threads:[~2020-11-11 12:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-11 10:08 Aaron Lauterer
2020-11-11 11:22 ` Thomas Lamprecht
2020-11-11 12:07 ` Dominik Csapak [this message]
2020-11-11 15:18 ` [pbs-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0bba9e97-55ff-6b0a-e69c-862af84d40b6@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox