From: Dominik Csapak <d.csapak@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Philipp Hufnagl <p.hufnagl@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] fix #4971: client: Improve output on successful snapshot deletion
Date: Thu, 12 Oct 2023 15:07:56 +0200 [thread overview]
Message-ID: <0ba969ca-6b72-46d7-b622-94e0e21acde9@proxmox.com> (raw)
In-Reply-To: <20231003140720.1635670-1-p.hufnagl@proxmox.com>
LGTM
Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Dominik Csapak <d.csapak@proxmox.com>
On 10/3/23 16:07, Philipp Hufnagl wrote:
> When a snapshot gets deleted (forgotten), the proxmox backup client
> currently returns returns
> "Result: {
> "data": null
> }"
>
> This feedback may confuse users therefore this patch changes the output
> to
>
> "Successfully deleted snapshot <snapshot>"
>
> Signed-off-by: Philipp Hufnagl <p.hufnagl@proxmox.com>
> ---
> proxmox-backup-client/src/snapshot.rs | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/proxmox-backup-client/src/snapshot.rs b/proxmox-backup-client/src/snapshot.rs
> index 4ca8015f..1d985a2e 100644
> --- a/proxmox-backup-client/src/snapshot.rs
> +++ b/proxmox-backup-client/src/snapshot.rs
> @@ -188,13 +188,14 @@ async fn forget_snapshots(param: Value) -> Result<Value, Error> {
>
> let path = format!("api2/json/admin/datastore/{}/snapshots", repo.store());
>
> - let result = client
> + client
> .delete(&path, Some(snapshot_args(&backup_ns, &snapshot)?))
> .await?;
>
> record_repository(&repo);
>
> - Ok(result)
> + println!("Successfully deleted snapshot {}", snapshot);
> + Ok(Value::Null)
> }
>
> #[api(
next prev parent reply other threads:[~2023-10-12 13:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-03 14:07 Philipp Hufnagl
2023-10-12 13:07 ` Dominik Csapak [this message]
2023-10-13 11:30 ` Thomas Lamprecht
2023-10-13 14:57 ` Philipp Hufnagl
2023-10-13 16:29 ` Thomas Lamprecht
2023-10-16 10:48 ` Philipp Hufnagl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ba969ca-6b72-46d7-b622-94e0e21acde9@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=p.hufnagl@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox