From: Dietmar Maurer <dietmar@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup] ui: tape: ChangerStatus fixup for empty barcode
Date: Fri, 14 May 2021 08:49:03 +0200 [thread overview]
Message-ID: <0b4c3710-69af-a42b-757b-ae1581ece8b4@proxmox.com> (raw)
In-Reply-To: <20210430094642.14243-1-d.csapak@proxmox.com>
applied
On 4/30/21 11:46 AM, Dominik Csapak wrote:
> empty barcode means that label-text is '', not undefined
> we forgot this line
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> www/tape/ChangerStatus.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/www/tape/ChangerStatus.js b/www/tape/ChangerStatus.js
> index f4bcc631..51ba6ffa 100644
> --- a/www/tape/ChangerStatus.js
> +++ b/www/tape/ChangerStatus.js
> @@ -224,7 +224,7 @@ Ext.define('PBS.TapeManagement.ChangerStatus', {
> return `${url}/${encodeURIComponent(drive)}/${apiCall}`;
> },
> items: [
> - label !== undefined ? {
> + label !== "" ? {
> xtype: 'displayfield',
> name: 'label-text',
> value: label,
prev parent reply other threads:[~2021-05-14 6:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-30 9:46 [pbs-devel] " Dominik Csapak
2021-05-14 6:49 ` Dietmar Maurer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b4c3710-69af-a42b-757b-ae1581ece8b4@proxmox.com \
--to=dietmar@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox