From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Matthias Heiserer <m.heiserer@proxmox.com>,
Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] close #3103: default lang
Date: Mon, 24 Jan 2022 09:59:57 +0100 [thread overview]
Message-ID: <09a6c918-6229-625c-fde1-e1bf0f1c9177@proxmox.com> (raw)
In-Reply-To: <f952c570-ded0-23c2-683e-235f15f7c9ff@proxmox.com>
On 24.01.22 09:54, Matthias Heiserer wrote:
> Are the style guidelines documented somewhere, e.g. in a rustfmt.toml file or the wiki? If so, I couldn't find them.
for rust we currently use the plain rustfmt settings, but it's not yet enforced
on build or the like and quite some files are not yet converted.
For new code we'd like to have it already correctly styled though, so using
rustfmt directly or through your editor and disregarding the changes from
unrelated code in the module would be the simplest way to ensure that.
Please do not sent format cleanups for the whole file, those are just big
and icky to handle over the list, that's best done by a maintainer directly.
- Thomas
prev parent reply other threads:[~2022-01-24 8:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-20 9:33 Matthias Heiserer
2022-01-20 12:04 ` Thomas Lamprecht
2022-01-24 8:54 ` Matthias Heiserer
2022-01-24 8:59 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09a6c918-6229-625c-fde1-e1bf0f1c9177@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=m.heiserer@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox