From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Christian Ebner <c.ebner@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox] s3 client: fix invalid request for empty delete_objects call
Date: Wed, 23 Jul 2025 15:48:00 +0200 [thread overview]
Message-ID: <08d9116e-cf96-4869-b317-3412e0948ec8@proxmox.com> (raw)
In-Reply-To: <20250723091357.353331-1-c.ebner@proxmox.com>
Am 23.07.25 um 11:15 schrieb Christian Ebner:
> The s3 client's object_delete method does not correctly handle cases
> where an empty list of object keys is passed via the parameters,
> resulting in an `invalid request` error.
>
> Handle this by early returning in case of an empty list, thereby also
> skipping the unneeded api request altogether.
>
> This indirectly fixes the snapshot directory cleanup for
> proxmox-backup-client benchmark or aborted backups, where no objects
> have been persisted to the object store within the snapshot prefix
> yet, therefore trying to delete the empty list.
>
> Reported-by: Dominik Csapak <d.csapak@proxmox.com>
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---
> Note: as this indirectly fixes an issue in PBS, latter must be build
> against a bumped version of the proxmox-s3-client.
>
> Further, I'm working on improving the error logging for such invalid
> requests, as they currently do not log the error in the response body
> (if any) in these cases.
>
> proxmox-s3-client/src/client.rs | 4 ++++
> proxmox-s3-client/src/response_reader.rs | 2 +-
> 2 files changed, 5 insertions(+), 1 deletion(-)
>
>
applied, thanks!
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2025-07-23 13:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-23 9:13 [pbs-devel] " Christian Ebner
2025-07-23 9:27 ` Christian Ebner
2025-07-23 13:48 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08d9116e-cf96-4869-b317-3412e0948ec8@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox