From: Dominik Csapak <d.csapak@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Hannes Laimer <h.laimer@proxmox.com>
Subject: Re: [pbs-devel] [PATCH v1 proxmox-backup 3/3] manager_bin: add --ignore-verified and --outdated-after parameters
Date: Fri, 11 Jun 2021 15:21:24 +0200 [thread overview]
Message-ID: <0871b037-d1ec-98c1-3f64-26b1f67210f5@proxmox.com> (raw)
In-Reply-To: <20210611075046.34449-4-h.laimer@proxmox.com>
comment inline:
On 6/11/21 09:50, Hannes Laimer wrote:
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
> src/bin/proxmox-backup-manager.rs | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/src/bin/proxmox-backup-manager.rs b/src/bin/proxmox-backup-manager.rs
> index c3806a31..e0baa20d 100644
> --- a/src/bin/proxmox-backup-manager.rs
> +++ b/src/bin/proxmox-backup-manager.rs
> @@ -269,6 +269,14 @@ async fn pull_datastore(
> "store": {
> schema: DATASTORE_SCHEMA,
> },
> + "ignore-verified": {
> + schema: IGNORE_VERIFIED_BACKUPS_SCHEMA,
> + optional: true,
> + },
> + "outdated-after": {
> + schema: VERIFICATION_OUTDATED_AFTER_SCHEMA,
> + optional: true,
> + },
> "output-format": {
> schema: OUTPUT_FORMAT,
> optional: true,
> @@ -286,7 +294,7 @@ async fn verify(
>
> let mut client = connect_to_localhost()?;
>
> - let args = json!({});
> + let args = json!(param);
>
caution, this still potentially contains the 'output-format' parameter
which will not work with the api, so we have to remove it here
(or use the 'extract_output_format' instead above)
> let path = format!("api2/json/admin/datastore/{}/verify", store);
>
>
prev parent reply other threads:[~2021-06-11 13:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-11 7:50 [pbs-devel] [PATCH v1 proxmox-backup 0/3] close #3459: add --ignore-verified and --outdated-after to CLI and api2 Hannes Laimer
2021-06-11 7:50 ` [pbs-devel] [PATCH v1 proxmox-backup 1/3] verify-job: move building of snapshot filter into function Hannes Laimer
2021-06-11 13:18 ` Dominik Csapak
2021-06-11 7:50 ` [pbs-devel] [PATCH v1 proxmox-backup 2/3] api2: add ignore-verified and outdated-after to datastore verify endpoint Hannes Laimer
2021-06-11 13:20 ` Dominik Csapak
2021-06-11 7:50 ` [pbs-devel] [PATCH v1 proxmox-backup 3/3] manager_bin: add --ignore-verified and --outdated-after parameters Hannes Laimer
2021-06-11 13:21 ` Dominik Csapak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0871b037-d1ec-98c1-3f64-26b1f67210f5@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=h.laimer@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox