Re: [pbs-devel] [PATCH proxmox-backup 2/2] ui: tape: increase tapestore interval

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

On 10.03.21 13:32, Dominik Csapak wrote:
> On 3/10/21 12:47 PM, Thomas Lamprecht wrote:
>> On 10.03.21 12:38, Dominik Csapak wrote:
>>>
>>>
>>> On 3/10/21 12:19 PM, Thomas Lamprecht wrote:
>>>> On 10.03.21 10:10, Dominik Csapak wrote:
>>>>> from 2 to 60 seconds. To retain the response time of the gui
>>>>> when adding/editing/removing, trigger a manual reload on these actions
>>>>>
>>>>> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
>>>>
>>>> Please add my Suggested-by or Reported-by tags for reference the next time,
>>>> thanks!
>>>>
>>>
>>> yes of course, sorry
>>
>> Thanks!
>>
>> btw. can you please freshen up my brain on the storeid config from UpdateStore?
>> As its not used there directly and it's base class Ext.data.Store only knows
>> about storeId [0] (note the casing difference), and using that one would actually
>> register the store to the Ext.data.StoreManager [1] and we could avoid the detour
>> over querying the nav tree but do a
>>
>> Ext.data.StoreManager.lookup('pbs-tape-drive-list').load();
>>
>> instead. Not sure about any extra cost of that manager, but code wise it would
>> be quite less (and only called from places where we know that PBS.enableTapeUI
>> is true already).
>>
>> And if the UpdateStores `storeid` property is only a "copy-is-my-hobby" left
>> over, or really misspelled then I'd maybe drop it or fix spelling, respectively.
>>
>> [0]: https://docs.sencha.com/extjs/6.0.1/classic/Ext.data.Store.html#cfg-storeId
>> [1]: https://docs.sencha.com/extjs/6.0.1/classic/Ext.data.StoreManager.html
> 
> mhmm after taking a short look at it, we require 'storeid' in the UpdateStore, otherwise it fails with an exception. But i cannot find
> any actual use for that, so i assume it was meant to be storeId in the
> first place but we never noticed

yeah so same findings I had.

> 
> i'll check if changing it to storeId has any negative side-effects
> (such as leftover stores after some panel gets destroyed) and would
> send patches to change all occurrences to storeId
> 
> if it's too costly (or has other issues) i'd prepare patches to
> drop it from the UpdateStore altogether (since we do not
> seem to use it)

Thanks!