public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Philipp Hufnagl <p.hufnagl@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: Re: [pbs-devel] [PATCH proxmox-backup 0/5] add context menu to datastore content
Date: Tue, 28 Nov 2023 13:48:52 +0100	[thread overview]
Message-ID: <06ffd5cd-8b2a-4cd5-b74a-e6181ecc84b1@proxmox.com> (raw)
In-Reply-To: <20231128094402.38115-1-d.csapak@proxmox.com>

LGTM


Tested-by: Philipp Hufnagl <p.hufnagl@proxmox.com>


On 11/28/23 10:43, Dominik Csapak wrote:
> and add a 'show information' window that includes the upload statistics.
> This also moves some actions from the column directly into a 'hamburger
> menu' so we don't overload the grid.
> 
> The only downside to this currently is that i could get keyboard
> navigation to work for the context menu or the hamburger menu, but i'm
> still looking into this.
> 
> This series replaces my old one for the upload statistics [0]
> 
> 
> 0: https://lists.proxmox.com/pipermail/pbs-devel/2023-August/006343.html
> 
> Dominik Csapak (5):
>   api-types: add an UploadStatistic api type
>   api: datastore admin: add 'snapshot-information' api call
>   ui: datastore content: add context menu to groups and snapshots
>   ui: datastore content: add snapshot information to context menu
>   ui: datastore content: add 'more actions' menu to actions
> 
>  pbs-api-types/src/datastore.rs |  36 +++++++
>  src/api2/admin/datastore.rs    | 117 +++++++++++++++++++--
>  www/Makefile                   |   1 +
>  www/datastore/Content.js       | 174 +++++++++++++++++++++++++++----
>  www/window/SnapshotInfo.js     | 182 +++++++++++++++++++++++++++++++++
>  5 files changed, 486 insertions(+), 24 deletions(-)
>  create mode 100644 www/window/SnapshotInfo.js
> 




  parent reply	other threads:[~2023-11-28 12:49 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-28  9:43 Dominik Csapak
2023-11-28  9:43 ` [pbs-devel] [PATCH proxmox-backup 1/5] api-types: add an UploadStatistic api type Dominik Csapak
2023-11-28  9:43 ` [pbs-devel] [PATCH proxmox-backup 2/5] api: datastore admin: add 'snapshot-information' api call Dominik Csapak
2023-11-28  9:44 ` [pbs-devel] [PATCH proxmox-backup 3/5] ui: datastore content: add context menu to groups and snapshots Dominik Csapak
2023-11-28 15:27   ` [pbs-devel] applied: " Thomas Lamprecht
2023-11-29  7:35     ` Dominik Csapak
2023-11-29  7:47       ` Thomas Lamprecht
2023-11-28  9:44 ` [pbs-devel] [PATCH proxmox-backup 4/5] ui: datastore content: add snapshot information to context menu Dominik Csapak
2023-11-28  9:44 ` [pbs-devel] [PATCH proxmox-backup 5/5] ui: datastore content: add 'more actions' menu to actions Dominik Csapak
2023-11-28 11:32 ` [pbs-devel] [PATCH proxmox-backup 0/5] add context menu to datastore content Fabian Grünbichler
2023-11-28 12:48 ` Philipp Hufnagl [this message]
2023-11-28 13:41 ` Max Carrara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=06ffd5cd-8b2a-4cd5-b74a-e6181ecc84b1@proxmox.com \
    --to=p.hufnagl@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal