From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>, markus frank <m.frank@proxmox.com>
Subject: [pbs-devel] applied: [PATCH v2 proxmox-backup] fix #3323: dry-run for cli backup subcommand
Date: Fri, 18 Feb 2022 15:10:20 +0100 [thread overview]
Message-ID: <06dcefe8-fc34-ad1f-3e97-f025de491b25@proxmox.com> (raw)
In-Reply-To: <20220218095538.2868974-1-m.frank@proxmox.com>
On 18.02.22 10:55, markus frank wrote:
> From: Markus Frank <m.frank@proxmox.com>
>
> adds a dry-run parameter for "proxmox-backup-client backup".
> With this parameter on it simply prints out what would be uploaded,
> instead of uploading it.
>
> Signed-off-by: Markus Frank <m.frank@proxmox.com>
> ---
> version 2:
> * tuple matching
> * print closure
>
> proxmox-backup-client/src/main.rs | 50 +++++++++++++++++++++++++------
> 1 file changed, 41 insertions(+), 9 deletions(-)
>
>
dropped one From header and applied, thanks!
Made two followups, one for the helper inline fn, i.e., repo was available in scope
so no need to pass it as param (question is if it's useful to repeat the same value
more than once anyway, but I kept it for now), and the second was for existing
non-ideal way the boolean/defaults where managed, the api macro is able to
handle that more comfortably and so that the default shows up in the CLI help.
prev parent reply other threads:[~2022-02-18 14:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-18 9:55 [pbs-devel] " markus frank
2022-02-18 10:12 ` Markus Frank
2022-02-18 14:10 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06dcefe8-fc34-ad1f-3e97-f025de491b25@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=m.frank@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox