public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pbs-devel] [PATCH proxmox-backup] ui: fix remove vanished tooltip to be valid for both sync directions
@ 2024-11-28 10:01 Christian Ebner
  2024-11-28 10:29 ` [pbs-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Christian Ebner @ 2024-11-28 10:01 UTC (permalink / raw)
  To: pbs-devel

The tooltip text shown for the remove vanished flag when hovering
is incorrect for push direction. By using `sync target` over `local`,
make the text agnostic to the actual sync direction.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
 www/window/SyncJobEdit.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/window/SyncJobEdit.js b/www/window/SyncJobEdit.js
index 1f47e016e..bcd2f2fb2 100644
--- a/www/window/SyncJobEdit.js
+++ b/www/window/SyncJobEdit.js
@@ -343,7 +343,7 @@ Ext.define('PBS.window.SyncJobEdit', {
 			name: 'remove-vanished',
 			autoEl: {
 			    tag: 'div',
-			    'data-qtip': gettext('Remove snapshots from local datastore if they vanished from source datastore?'),
+			    'data-qtip': gettext('Remove snapshots from sync target datastore if they vanished from source datastore?'),
 			},
 			uncheckedValue: false,
 			value: false,
-- 
2.39.5



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pbs-devel] applied: [PATCH proxmox-backup] ui: fix remove vanished tooltip to be valid for both sync directions
  2024-11-28 10:01 [pbs-devel] [PATCH proxmox-backup] ui: fix remove vanished tooltip to be valid for both sync directions Christian Ebner
@ 2024-11-28 10:29 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2024-11-28 10:29 UTC (permalink / raw)
  To: Proxmox Backup Server development discussion, Christian Ebner

Am 28.11.24 um 11:01 schrieb Christian Ebner:
> The tooltip text shown for the remove vanished flag when hovering
> is incorrect for push direction. By using `sync target` over `local`,
> make the text agnostic to the actual sync direction.
> 
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---
>  www/window/SyncJobEdit.js | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
>

applied, thanks!


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-11-28 10:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-11-28 10:01 [pbs-devel] [PATCH proxmox-backup] ui: fix remove vanished tooltip to be valid for both sync directions Christian Ebner
2024-11-28 10:29 ` [pbs-devel] applied: " Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal