[pbs-devel] [PATCH proxmox-backup 1/2] ui: form/DriveSelector: do not autoselect the drive

[pbs-devel] [PATCH proxmox-backup 1/2] ui: form/DriveSelector: do not autoselect the drive

[Dominik Csapak]

in case an invalid drive was configured, now it marks the field invalid
instead of autoselecting the first valid one

this could have lead to users configuring the wrong drive in a tape-backup-job
when they edited one

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/tape/form/DriveSelector.js | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/www/tape/form/DriveSelector.js b/www/tape/form/DriveSelector.js
index 333989a9..9c793e46 100644
--- a/www/tape/form/DriveSelector.js
+++ b/www/tape/form/DriveSelector.js
@@ -16,6 +16,8 @@ Ext.define('PBS.form.DriveSelector', {
 	sorters: 'name',
     },
 
+    autoSelect: false,
+
     listConfig: {
 	columns: [
 	    {
-- 
2.20.1

[pbs-devel] [PATCH proxmox-backup 2/2] ui: tape/TapeBackupJob: use correct default value for pbsUserSelector

[Dominik Csapak]

if we want the empty value as a valid default value in a combogrid, we
have to explicitely select 'null' else the field will be marked as
dirty

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/tape/window/TapeBackupJob.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/www/tape/window/TapeBackupJob.js b/www/tape/window/TapeBackupJob.js
index 4c80e799..c5541d87 100644
--- a/www/tape/window/TapeBackupJob.js
+++ b/www/tape/window/TapeBackupJob.js
@@ -70,6 +70,7 @@ Ext.define('PBS.TapeManagement.BackupJobEdit', {
 		fieldLabel: gettext('Notify User'),
 		emptyText: 'root@pam',
 		allowBlank: true,
+		value: null,
 		renderer: Ext.String.htmlEncode,
 	    },
 	],
-- 
2.20.1

[pbs-devel] applied: [PATCH proxmox-backup 2/2] ui: tape/TapeBackupJob: use correct default value for pbsUserSelector

[Thomas Lamprecht]

On 07.06.21 15:06, Dominik Csapak wrote:
> if we want the empty value as a valid default value in a combogrid, we
> have to explicitely select 'null' else the field will be marked as
> dirty
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  www/tape/window/TapeBackupJob.js | 1 +
>  1 file changed, 1 insertion(+)
> 
>

applied, thanks!

[pbs-devel] applied: [PATCH proxmox-backup 1/2] ui: form/DriveSelector: do not autoselect the drive

[Thomas Lamprecht]

On 07.06.21 15:06, Dominik Csapak wrote:
> in case an invalid drive was configured, now it marks the field invalid
> instead of autoselecting the first valid one
> 
> this could have lead to users configuring the wrong drive in a tape-backup-job
> when they edited one
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  www/tape/form/DriveSelector.js | 2 ++
>  1 file changed, 2 insertions(+)
> 
>

applied this already, but it should be obsolete once we bump widget-toolkit with my
patch for combo grid, at least if that patch does not causes problems and can stay.