From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Philipp Hufnagl <p.hufnagl@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] fix #4971: client: Improve output on successful snapshot deletion
Date: Fri, 13 Oct 2023 13:30:05 +0200 [thread overview]
Message-ID: <04c63a91-3e4c-43a8-855e-44c1680f366e@proxmox.com> (raw)
In-Reply-To: <20231003140720.1635670-1-p.hufnagl@proxmox.com>
Am 03/10/2023 um 16:07 schrieb Philipp Hufnagl:
> - Ok(result)
> + println!("Successfully deleted snapshot {}", snapshot);
please use inline variables wherever easily possible for new code:
println!("Successfully deleted snapshot {snapshot}");
but I'm not sure if we actually want to print anything here, did you
check what the other "action" (i.e., non-GET ones) do, If they all,
or at least most of them, print such reports too it can be fine, but
otherwise this would add inconsistency and simply doing nothing (i.e.,
exiting with SUCCESS) would be enough.
next prev parent reply other threads:[~2023-10-13 11:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-03 14:07 Philipp Hufnagl
2023-10-12 13:07 ` Dominik Csapak
2023-10-13 11:30 ` Thomas Lamprecht [this message]
2023-10-13 14:57 ` Philipp Hufnagl
2023-10-13 16:29 ` Thomas Lamprecht
2023-10-16 10:48 ` Philipp Hufnagl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04c63a91-3e4c-43a8-855e-44c1680f366e@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=p.hufnagl@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox