From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>, Oguz Bektas <o.bektas@proxmox.com>
Subject: [pbs-devel] applied: Re: [PATCH proxmox-backup] add local-zfs.rst
Date: Wed, 8 Jul 2020 18:21:16 +0200 [thread overview]
Message-ID: <04799f43-b833-2114-0769-a3da133819f7@proxmox.com> (raw)
In-Reply-To: <20200708124148.359379-1-o.bektas@proxmox.com>
On 08.07.20 14:41, Oguz Bektas wrote:
> content is > 90% same as local-zfs.adoc in pve-docs.
>
> adapted the format for .rst
>
> fixed some typos and wrote some parts slightly different (wording).
>
> Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
> ---
> docs/local-zfs.rst | 374 +++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 374 insertions(+)
> create mode 100644 docs/local-zfs.rst
>
>
applied, but there's quite a few things to fix. What reStructured text really likes
are a empty line between a special directive and its content. For example, code-block:
>.. code-block:: console
>
> options zfs zfs_arc_max=8589934592
You missed that empty line everywhere. Simple tables have also some rules to follow.
I Included this in sysadmin.rst and move that out as it's own chapter.
next prev parent reply other threads:[~2020-07-08 16:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 12:41 [pbs-devel] " Oguz Bektas
2020-07-08 16:21 ` Thomas Lamprecht [this message]
2020-07-09 8:37 ` [pbs-devel] applied: " Oguz Bektas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04799f43-b833-2114-0769-a3da133819f7@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=o.bektas@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox