Re: [pbs-devel] [PATCH proxmox-backup v2 4/4] ui: expose rate and burst limits for s3 endpoints

[Hannes Laimer <h.laimer@proxmox.com>]

Reviewed-by: Hannes Laimer <h.laimer@proxmox.com>
Tested-by: Hannes Laimer <h.laimer@proxmox.com>

On 9/16/25 14:42, Christian Ebner wrote:
> Allows to configure the s3 endpoints rate limits via the advanced
> options.
> 
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---
> Changes since version 1:
> - no changes
> 
>   www/window/S3ClientEdit.js | 34 ++++++++++++++++++++++++++++++++++
>   1 file changed, 34 insertions(+)
> 
> diff --git a/www/window/S3ClientEdit.js b/www/window/S3ClientEdit.js
> index 269b35967..8862683b8 100644
> --- a/www/window/S3ClientEdit.js
> +++ b/www/window/S3ClientEdit.js
> @@ -121,6 +121,20 @@ Ext.define('PBS.window.S3ClientEdit', {
>           ],
>   
>           advancedColumn1: [
> +            {
> +                xtype: 'pmxBandwidthField',
> +                name: 'rate-in',
> +                fieldLabel: gettext('Rate In'),
> +                emptyText: gettext('Unlimited'),
> +                submitAutoScaledSizeUnit: true,
> +            },
> +            {
> +                xtype: 'pmxBandwidthField',
> +                name: 'rate-out',
> +                fieldLabel: gettext('Rate Out'),
> +                emptyText: gettext('Unlimited'),
> +                submitAutoScaledSizeUnit: true,
> +            },
>               {
>                   xtype: 'proxmoxKVComboBox',
>                   name: 'provider-quirks',
> @@ -136,6 +150,22 @@ Ext.define('PBS.window.S3ClientEdit', {
>                   },
>               },
>           ],
> +        advancedColumn2: [
> +            {
> +                xtype: 'pmxBandwidthField',
> +                name: 'burst-in',
> +                fieldLabel: gettext('Burst In'),
> +                emptyText: gettext('Same as Rate'),
> +                submitAutoScaledSizeUnit: true,
> +            },
> +            {
> +                xtype: 'pmxBandwidthField',
> +                name: 'burst-out',
> +                fieldLabel: gettext('Burst Out'),
> +                emptyText: gettext('Same as Rate'),
> +                submitAutoScaledSizeUnit: true,
> +            },
> +        ],
>       },
>   
>       getValues: function () {
> @@ -146,6 +176,10 @@ Ext.define('PBS.window.S3ClientEdit', {
>               values.delete = values.delete.split(',');
>           }
>           PBS.Utils.delete_if_default(values, 'path-style', false, me.isCreate);
> +        PBS.Utils.delete_if_default(values, 'rate-in', undefined, me.isCreate);
> +        PBS.Utils.delete_if_default(values, 'burst-in', undefined, me.isCreate);
> +        PBS.Utils.delete_if_default(values, 'rate-out', undefined, me.isCreate);
> +        PBS.Utils.delete_if_default(values, 'burst-out', undefined, me.isCreate);
>   
>           let https_scheme_prefix = 'https://';
>           if (values.endpoint.startsWith(https_scheme_prefix)) {



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel