From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Philipp Hufnagl <p.hufnagl@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup v3] docs: replace concrete device paths with pseudo paths
Date: Mon, 17 Jul 2023 16:02:04 +0200 [thread overview]
Message-ID: <0399ccdf-257a-6830-48e2-6c421b5adc28@proxmox.com> (raw)
In-Reply-To: <20230711075651.16375-1-p.hufnagl@proxmox.com>
Am 11/07/2023 um 09:56 schrieb Philipp Hufnagl:
> Having commonly used device paths (like /dev/sdb) in an example command
> may cause damage if the user simply copies them without checking. With a
> pseudo device path (like /dev/sdX), they would simply get an error
>
> Signed-off-by: Philipp Hufnagl <p.hufnagl@proxmox.com>
> ---
what I forgot, please add a patch changelog here in this area, that way
review gets much easier but this meta info doesn't gets added to the
commit when applying the patch, e.g.:
changes from v2:
* fixed this and that
* ...
prev parent reply other threads:[~2023-07-17 14:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-11 7:56 Philipp Hufnagl
2023-07-11 8:35 ` Lukas Wagner
2023-07-17 13:57 ` [pbs-devel] applied: " Thomas Lamprecht
2023-07-17 14:02 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0399ccdf-257a-6830-48e2-6c421b5adc28@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=p.hufnagl@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox