public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>,
	Hannes Laimer <h.laimer@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup] proxy: rrd: skip update disk stats for offline datastores
Date: Thu, 12 May 2022 11:53:23 +0200	[thread overview]
Message-ID: <02887f82-ed5e-d5fc-e780-afed21ea7ede@proxmox.com> (raw)
In-Reply-To: <20220504054906.9218-1-h.laimer@proxmox.com>

Am 5/4/22 um 07:49 schrieb Hannes Laimer:
> RDD update did not use lookup_datastore() and therefore bypassed
> the maintenance mode checks. This adds the needed check directly.
> 
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
>  src/bin/proxmox-backup-proxy.rs | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
>

applied, thanks!

But there was a similar issue in the schedule_datastore_garbage_collection fn,
which tried to look up the Datastore with a Write operation at the very start,
before even checking if GC for that store is scheduled at all and if it would be
pending now, and the actual problematic check if GC is already running (which needs
a datastore instance, so just moving the lookup code downward couldn't be the single
solution).

For that I added a new Lookup operation in a limited scope, and then open the
datastore with the Write op only directly before actually wanting to start GC,
at which point a log entry is ok.




      reply	other threads:[~2022-05-12  9:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-04  5:49 [pbs-devel] " Hannes Laimer
2022-05-12  9:53 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=02887f82-ed5e-d5fc-e780-afed21ea7ede@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=h.laimer@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal