From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Shannon Sterz <s.sterz@proxmox.com>
Cc: Lukas Wagner <l.wagner@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] notifications: adapt to proxmox-apt making old_version optional
Date: Thu, 13 Nov 2025 13:16:00 +0100 [thread overview]
Message-ID: <01a612c8-42b3-4d75-86b2-80a88c3a0262@proxmox.com> (raw)
In-Reply-To: <20251113114014.308133-1-s.sterz@proxmox.com>
Am 13.11.25 um 12:40 schrieb Shannon Sterz:
> Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
> ---
> src/server/notifications/template_data.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/server/notifications/template_data.rs b/src/server/notifications/template_data.rs
> index 0dcc5ed3..9adc4699 100644
> --- a/src/server/notifications/template_data.rs
> +++ b/src/server/notifications/template_data.rs
> @@ -177,7 +177,7 @@ impl PackageUpdatesTemplateData {
> .map(|info| UpgradablePackage {
> package_name: info.package.clone(),
> available_version: info.version.clone(),
> - installed_version: info.old_version.clone(),
> + installed_version: info.old_version.clone().unwrap_or_default(),
> })
> .collect(),
> }
What about adapting installed_version to reality and make it also an
option? I mean, depends a bit on how handlebars will handle such things
then, and also how willing we're adopting light breakage if it fixes
wrong historic assumptions.
Our shipped template for this default/package-updates-body.txt.hbs should
be updated in any case though, maybe special case the no installed_version,
be that None or "", and add a NEW or something like that there.
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2025-11-13 12:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-13 11:40 Shannon Sterz
2025-11-13 12:16 ` Thomas Lamprecht [this message]
2025-11-13 12:45 ` Shannon Sterz
2025-11-13 12:47 ` Lukas Wagner
2025-11-13 12:55 ` [pbs-devel] Superseded: " Shannon Sterz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01a612c8-42b3-4d75-86b2-80a88c3a0262@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=s.sterz@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox