public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Filip Schauer <f.schauer@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
	Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH backup v2 2/2] disks: wipe: only zero out the first 1 MiB
Date: Wed, 12 Feb 2025 11:24:35 +0100	[thread overview]
Message-ID: <01a0b4f9-c8e2-49b2-ad64-a9cfc42a1e77@proxmox.com> (raw)
In-Reply-To: <4b0509f6-98e2-46e7-ad13-5e54bb13834c@proxmox.com>

On 11/02/2025 19:42, Thomas Lamprecht wrote:
> I have some faint remembrance that we had to increase the area we zero
> out for ceph OSDs and/or for the installer.

You are right. We zero out the first 200 MiB to prevent a problem with
OSD creation. [0] [1] Although I am unable to reproduce this on Ceph
Quincy, making sure the disk is properly wiped does not hurt. So we can
drop this patch.

[0] 
https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=1b3caf4f2153bff3c0db7726275a571fbd1f07e0
[1] https://tracker.ceph.com/issues/22354



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


  reply	other threads:[~2025-02-12 10:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-11 16:26 [pbs-devel] [PATCH backup v2 0/2] fix #5946: disks: wipe: ensure GPT header backup is wiped Filip Schauer
2025-02-11 16:26 ` [pbs-devel] [PATCH backup v2 1/2] " Filip Schauer
2025-02-11 18:39   ` Thomas Lamprecht
2025-02-12 11:01     ` Filip Schauer
2025-02-11 16:26 ` [pbs-devel] [PATCH backup v2 2/2] disks: wipe: only zero out the first 1 MiB Filip Schauer
2025-02-11 18:42   ` Thomas Lamprecht
2025-02-12 10:24     ` Filip Schauer [this message]
2025-02-12 13:44       ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=01a0b4f9-c8e2-49b2-ad64-a9cfc42a1e77@proxmox.com \
    --to=f.schauer@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal