From: Lukas Wagner <l.wagner@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Maximiliano Sandoval <m.sandoval@proxmox.com>
Subject: Re: [pbs-devel] [PATCH backup 4/5] fix typos in strings
Date: Fri, 9 Aug 2024 13:17:00 +0200 [thread overview]
Message-ID: <009e7a3f-a1c2-47ea-9472-8168ffd1551e@proxmox.com> (raw)
In-Reply-To: <43893cf8-c877-4805-9684-abfd5c9bf6d9@proxmox.com>
On 2024-08-07 16:48, Thomas Lamprecht wrote:
> On 07/08/2024 12:52, Lukas Wagner wrote:
>> On 2024-08-07 12:32, Maximiliano Sandoval wrote:
>>> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
>>> ---
>>> docs/lto-barcode/page-calibration.js | 8 ++++----
>>> pbs-api-types/src/ldap.rs | 2 +-
>>> src/api2/node/tasks.rs | 2 +-
>>> 3 files changed, 6 insertions(+), 6 deletions(-)
>>>
>>> diff --git a/docs/lto-barcode/page-calibration.js b/docs/lto-barcode/page-calibration.js
>>> index 3c7fed82..54512a9f 100644
>>> --- a/docs/lto-barcode/page-calibration.js
>>> +++ b/docs/lto-barcode/page-calibration.js
>>> @@ -108,7 +108,7 @@ Ext.define('PageCalibration', {
>>> xtype: 'numberfield',
>>> value: 'a4',
>>> name: 's_x',
>>> - fieldLabel: 'Meassured Start Offset Sx (mm)',
>>> + fieldLabel: 'Measured Start Offset Sx (mm)',
>>
>> I wonder, shouldn't these use gettext?
>>
>
> The LTO barcode label tool [0] has no gettext infra and is currently also not
> considered when extracting texts for the i18n repo. In that small app the
> gettext function is defined as identity function [1] just to avoid that the
> widget-toolkit breaks.
>
> While we could naturally add i18n support, the LTO barcode label app is a
> 1) rather niche tool and 2) not really complex, so it might be a bit overkill,
> at least without users requesting i18n support there.
Ah right, thx for the explanation!
--
- Lukas
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2024-08-09 11:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-07 10:32 [pbs-devel] [PATCH backup 1/5] fix typos in comments Maximiliano Sandoval
2024-08-07 10:32 ` [pbs-devel] [PATCH backup 2/5] fix typos in rust documentation blocks Maximiliano Sandoval
2024-08-07 10:49 ` Gabriel Goller
2024-08-07 12:09 ` Maximiliano Sandoval
2024-08-07 10:32 ` [pbs-devel] [PATCH backup 3/5] fix typos in docs an manual pages Maximiliano Sandoval
2024-08-07 10:32 ` [pbs-devel] [PATCH backup 4/5] fix typos in strings Maximiliano Sandoval
2024-08-07 10:52 ` Lukas Wagner
2024-08-07 14:48 ` Thomas Lamprecht
2024-08-09 11:17 ` Lukas Wagner [this message]
2024-08-07 10:32 ` [pbs-devel] [PATCH backup 5/5] fix typos in variables and function names Maximiliano Sandoval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=009e7a3f-a1c2-47ea-9472-8168ffd1551e@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=m.sandoval@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox