public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>,
	Aaron Lauterer <a.lauterer@proxmox.com>
Subject: [pbs-devel] applied-series: [PATCH proxmox-backup 0/5] add/fix help buttons
Date: Tue, 10 Nov 2020 11:52:44 +0100	[thread overview]
Message-ID: <00055105-1f60-6b41-4c7e-d801ac690e23@proxmox.com> (raw)
In-Reply-To: <20201110104543.24040-1-a.lauterer@proxmox.com>

On 10.11.20 11:45, Aaron Lauterer wrote:
> The following series does the following:
> * adds more help buttons where appropriate
> * fixes not working help buttons
>     * by adding more references where needed
>     * changing the scanrefs script to add all references found in the
>       docs as it would not add references needed in the widget toolkit
>       in its current state. Something we will need to take another look
>       at in the future.
>     * fixing references in the docs/ui to match
> 
> In order for all the help buttons to work, the recent patch in the
> widget-toolkit which fixed the dash/underscore normalization needs to be
> applied [0].
> 
> 
> [0] https://lists.proxmox.com/pipermail/pve-devel/2020-November/045868.html
> 
> Aaron Lauterer (5):
>   scanrefs: only scan docs, not JS files
>   docs: add maintenance chapter prefix to verification ref
>   docs: add network management reference
>   ui: add all online help refs found in docs
>   ui: add/fix help buttons
> 
>  docs/_ext/proxmox-scanrefs.py | 25 ++++++++++--------
>  docs/gui.rst                  |  2 +-
>  docs/maintenance.rst          |  2 +-
>  docs/network-management.rst   |  2 ++
>  www/OnlineHelpInfo.js         | 48 +++++++++++++++++++++++++++++++++++
>  www/datastore/PruneAndGC.js   |  2 ++
>  www/window/CreateDirectory.js |  2 ++
>  www/window/TokenEdit.js       |  2 +-
>  www/window/VerifyJobEdit.js   |  2 +-
>  9 files changed, 73 insertions(+), 14 deletions(-)
> 


applied series, thanks! FYI: Had to resolve a small conflict in OnlineHelpInfo.js in
patch 4/5.




      parent reply	other threads:[~2020-11-10 10:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-10 10:45 [pbs-devel] " Aaron Lauterer
2020-11-10 10:45 ` [pbs-devel] [PATCH proxmox-backup 1/5] scanrefs: only scan docs, not JS files Aaron Lauterer
2020-11-10 10:45 ` [pbs-devel] [PATCH proxmox-backup 2/5] docs: add maintenance chapter prefix to verification ref Aaron Lauterer
2020-11-10 10:45 ` [pbs-devel] [PATCH proxmox-backup 3/5] docs: add network management reference Aaron Lauterer
2020-11-10 10:45 ` [pbs-devel] [PATCH proxmox-backup 4/5] ui: add all online help refs found in docs Aaron Lauterer
2020-11-10 10:45 ` [pbs-devel] [PATCH proxmox-backup 5/5] ui: add/fix help buttons Aaron Lauterer
2020-11-10 10:52 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=00055105-1f60-6b41-4c7e-d801ac690e23@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=a.lauterer@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal