From: "DERUMIER, Alexandre via pve-devel" <pve-devel@lists.proxmox.com>
To: "pve-devel@lists.proxmox.com" <pve-devel@lists.proxmox.com>,
"f.gruenbichler@proxmox.com" <f.gruenbichler@proxmox.com>
Cc: "DERUMIER, Alexandre" <alexandre.derumier@groupe-cyllene.com>
Subject: Re: [pve-devel] [PATCH pve-storage 08/10] qcow2: add external snapshot support
Date: Fri, 4 Jul 2025 13:22:52 +0000 [thread overview]
Message-ID: <mailman.996.1751635413.395.pve-devel@lists.proxmox.com> (raw)
In-Reply-To: <2064112819.2237.1751629966392@webmail.proxmox.com>
[-- Attachment #1: Type: message/rfc822, Size: 17423 bytes --]
From: "DERUMIER, Alexandre" <alexandre.derumier@groupe-cyllene.com>
To: "pve-devel@lists.proxmox.com" <pve-devel@lists.proxmox.com>, "f.gruenbichler@proxmox.com" <f.gruenbichler@proxmox.com>
Subject: Re: [pve-devel] [PATCH pve-storage 08/10] qcow2: add external snapshot support
Date: Fri, 4 Jul 2025 13:22:52 +0000
Message-ID: <c38598bae6477dfa6af0db96da054b156698d41c.camel@groupe-cyllene.com>
> + snapext => { optional => 1 },
>>needs to be "fixed", as the code doesn't handle mixing internal
>>and external snapshots on a single storage..
indeed, I'll fix it
>
>
> +my sub alloc_backed_image {
> + my ($class, $storeid, $scfg, $volname, $backing_snap) = @_;
> +
> + my $path = $class->path($scfg, $volname, $storeid);
> + my $backing_path = $class->path($scfg, $volname, $storeid,
> $backing_snap);
>>should we use a relative path here like we do when doing a linked
>>clone? else
>>it basically means that it is no longer possible to move the storage
>>mountpoint,
>>unless I am mistaken?
I dind't have thinked about mountpoint change, but yes, I'll not work
anymore without related path.
> + #delete external snapshots
> + if ($scfg->{snapext}) {
> + my $snapshots = $class->volume_snapshot_info($scfg,
> $storeid, $volname);
> + for my $snapid (
> + sort { $snapshots->{$b}->{order} <=> $snapshots-
> >{$a}->{order} }
> + keys %$snapshots
> + ) {
> + my $snap = $snapshots->{$snapid};
> + next if $snapid eq 'current';
> + next if !$snap->{ext};
> + free_snap_image($class, $storeid, $scfg, $volname,
> $snapid);
> + }
> + }
> +
>>this is a bit tricky.. once we've deleted the first snapshot, we've
>>basically invalidated
>>the whole image..
Well, we want to delete it anyway, we don't care about invalidate it ?
>> should we try to continue freeing as much as possible? and maybe
even
>>start with the "current" image, so that a partial removal doesn't
>>look like valid image
>>anymore?
currently the volume_snapshot_info is reading the snapshot chain from
the current image (to do only 1 qemu-img call), that why I'm removing
snapshots in reverse order.
If something hang with partial delete, you can still try again later.
If we want to delete from the current to last snap, I'll need something
like calling qemu-info info on each snap file to find each parent.
or maybe use something else than volume_snapshot_info here, simply glob
all the vm disk && snap files and delete them in random order, as we
want to delete it anyway.
>>the naming scheme here still clashes with regular volids
unfortunately:
>>$ pvesm alloc ext4 12344321 snap-foobar-12344321-disk-foofoobar.qcow2
>>1G
>>Formatting '/mnt/pve/ext4/images/12344321/snap-foobar-12344321-disk-
>>foofoobar.qcow2', fmt=qcow2 cluster_size=65536 extended_l2=off
>>preallocation=off compression_type=zlib size=1073741824
>>lazy_refcounts=off refcount_bits=16
>>successfully created 'ext4:12344321/snap-foobar-12344321-disk-
>>foofoobar.qcow2'
>>$ pvesm list ext4 -content images -vmid 12344321 | grep foobar
>>ext4:12344321/snap-foobar-12344321-disk-foofoobar.qcow2 qcow2
>>images 1073741824 12344321
>>$ qm set 12344321 --scsi0 ext4:12344321/snap-foobar-12344321-disk-
>>foofoobar.qcow2
>>should we maybe move snapshot files into a subdir, since `/` is not
>>allowed in volnames?
what about lvm ? (I think it should be great to have same scheme for
both, but lvm have also reserved characters like @)
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-07-04 13:22 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250704064507.511884-1-alexandre.derumier@groupe-cyllene.com>
2025-07-04 6:44 ` [pve-devel] [PATCH qemu-server 1/3] qemu_img convert : " Alexandre Derumier via pve-devel
2025-07-04 6:44 ` [pve-devel] [PATCH pve-storage 01/10] tests: add lvmplugin test Alexandre Derumier via pve-devel
2025-07-04 6:44 ` [pve-devel] [PATCH qemu-server 2/3] blockdev: add backing_chain support Alexandre Derumier via pve-devel
2025-07-04 6:44 ` [pve-devel] [PATCH pve-storage 02/10] common: add qemu_img_create an preallocation_cmd_option Alexandre Derumier via pve-devel
2025-07-04 11:53 ` Fabian Grünbichler
2025-07-04 12:33 ` DERUMIER, Alexandre via pve-devel
[not found] ` <51f988f11e60f9dfaa49658c1ed9ecf72fcfcde4.camel@groupe-cyllene.com>
2025-07-07 7:55 ` Fabian Grünbichler
2025-07-04 6:44 ` [pve-devel] [PATCH pve-storage 03/10] common: qemu_img_create: add backing_file support Alexandre Derumier via pve-devel
2025-07-04 11:52 ` Fabian Grünbichler
2025-07-04 12:31 ` DERUMIER, Alexandre via pve-devel
2025-07-07 7:16 ` DERUMIER, Alexandre via pve-devel
2025-07-04 6:45 ` [pve-devel] [PATCH qemu-server 3/3] qcow2: add external snapshot support Alexandre Derumier via pve-devel
2025-07-04 11:52 ` Fabian Grünbichler
2025-07-04 12:46 ` DERUMIER, Alexandre via pve-devel
2025-07-04 6:45 ` [pve-devel] [PATCH pve-storage 04/10] rename_volume: add source && target snap Alexandre Derumier via pve-devel
2025-07-04 11:52 ` Fabian Grünbichler
2025-07-04 12:04 ` Thomas Lamprecht
2025-07-07 10:34 ` DERUMIER, Alexandre via pve-devel
2025-07-04 6:45 ` [pve-devel] [PATCH pve-storage 05/10] common: add qemu_img_info helper Alexandre Derumier via pve-devel
2025-07-04 6:45 ` [pve-devel] [PATCH pve-storage 06/10] common: add qemu-img measure Alexandre Derumier via pve-devel
2025-07-04 11:51 ` Fabian Grünbichler
2025-07-04 6:45 ` [pve-devel] [PATCH pve-storage 07/10] storage: volume_snapshot: add $running param Alexandre Derumier via pve-devel
2025-07-04 11:52 ` Fabian Grünbichler
2025-07-04 6:45 ` [pve-devel] [PATCH pve-storage 08/10] qcow2: add external snapshot support Alexandre Derumier via pve-devel
2025-07-04 11:52 ` Fabian Grünbichler
2025-07-04 13:22 ` DERUMIER, Alexandre via pve-devel [this message]
[not found] ` <c38598bae6477dfa6af0db96da054b156698d41c.camel@groupe-cyllene.com>
2025-07-07 8:17 ` Fabian Grünbichler
2025-07-07 10:18 ` DERUMIER, Alexandre via pve-devel
[not found] ` <c671fe82a7cdab90a3691115a7132d0a35ae79b7.camel@groupe-cyllene.com>
2025-07-07 10:53 ` Fabian Grünbichler
2025-07-08 8:44 ` DERUMIER, Alexandre via pve-devel
[not found] ` <3d1d8516e3c68de370608033647a38e99ef50f23.camel@groupe-cyllene.com>
2025-07-08 8:56 ` Fabian Grünbichler
2025-07-08 11:37 ` DERUMIER, Alexandre via pve-devel
2025-07-08 10:04 ` DERUMIER, Alexandre via pve-devel
[not found] ` <27854af70a4fe3a7765d2760098e2f82f3475f17.camel@groupe-cyllene.com>
2025-07-08 10:59 ` Fabian Grünbichler
2025-07-08 11:35 ` DERUMIER, Alexandre via pve-devel
[not found] ` <0b2ba0c34d2c8c15d7cb642442b300a3180e1592.camel@groupe-cyllene.com>
2025-07-08 12:50 ` Thomas Lamprecht
2025-07-08 13:19 ` DERUMIER, Alexandre via pve-devel
2025-07-08 13:42 ` DERUMIER, Alexandre via pve-devel
[not found] ` <67627e7904281520e1f7152657ed00c7ba3c138b.camel@groupe-cyllene.com>
2025-07-08 14:18 ` Fabian Grünbichler
2025-07-09 12:52 ` DERUMIER, Alexandre via pve-devel
2025-07-04 6:45 ` [pve-devel] [PATCH pve-storage 09/10] lvmplugin: add qcow2 snapshot Alexandre Derumier via pve-devel
2025-07-04 11:51 ` Fabian Grünbichler
2025-07-09 7:24 ` DERUMIER, Alexandre via pve-devel
2025-07-09 8:06 ` DERUMIER, Alexandre via pve-devel
2025-07-04 6:45 ` [pve-devel] [PATCH pve-storage 10/10] storage : add volume_support_qemu_snapshot Alexandre Derumier via pve-devel
2025-07-04 11:51 ` Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mailman.996.1751635413.395.pve-devel@lists.proxmox.com \
--to=pve-devel@lists.proxmox.com \
--cc=alexandre.derumier@groupe-cyllene.com \
--cc=f.gruenbichler@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal