all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Alexandre Derumier via pve-devel <pve-devel@lists.proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: Alexandre Derumier <alexandre.derumier@groupe-cyllene.com>
Subject: [pve-devel] [PATCH pve-storage 10/10] storage : add volume_support_qemu_snapshot
Date: Fri,  4 Jul 2025 08:45:07 +0200	[thread overview]
Message-ID: <mailman.965.1751611555.395.pve-devel@lists.proxmox.com> (raw)
In-Reply-To: <20250704064507.511884-1-alexandre.derumier@groupe-cyllene.com>

[-- Attachment #1: Type: message/rfc822, Size: 6532 bytes --]

From: Alexandre Derumier <alexandre.derumier@groupe-cyllene.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH pve-storage 10/10] storage : add volume_support_qemu_snapshot
Date: Fri,  4 Jul 2025 08:45:07 +0200
Message-ID: <20250704064507.511884-14-alexandre.derumier@groupe-cyllene.com>

Returns if the volume is supporting qemu snapshot:
 'internal' : do the snapshot with qemu internal snapshot
 'external' : do the snapshot with qemu external snapshot
  undef     : does not support qemu snapshot

Signed-off-by: Alexandre Derumier <alexandre.derumier@groupe-cyllene.com>
---
 src/PVE/Storage.pm           | 19 +++++++++++++++++++
 src/PVE/Storage/DirPlugin.pm | 10 ++++++++++
 src/PVE/Storage/LVMPlugin.pm |  7 +++++++
 src/PVE/Storage/Plugin.pm    | 13 +++++++++++++
 src/PVE/Storage/RBDPlugin.pm |  6 ++++++
 5 files changed, 55 insertions(+)

diff --git a/src/PVE/Storage.pm b/src/PVE/Storage.pm
index d83770c..e794f7b 100755
--- a/src/PVE/Storage.pm
+++ b/src/PVE/Storage.pm
@@ -2350,6 +2350,25 @@ sub rename_volume {
     );
 }
 
+# Returns the method type to take a snapshot with qemu:
+# 'internal' : support snapshot with qemu internal snapshot
+# 'external' : support do the snapshot with qemu external snapshot
+# undef : don't support qemu snapshot
+sub volume_support_qemu_snapshot {
+    my ($cfg, $volid) = @_;
+
+    my ($storeid, $volname) = parse_volume_id($volid, 1);
+
+    if ($storeid) {
+        my $scfg = storage_config($cfg, $storeid);
+
+        my $plugin = PVE::Storage::Plugin->lookup($scfg->{type});
+
+        return $plugin->volume_support_qemu_snapshot($storeid, $scfg, $volname);
+    }
+    return undef;
+}
+
 # Various io-heavy operations require io/bandwidth limits which can be
 # configured on multiple levels: The global defaults in datacenter.cfg, and
 # per-storage overrides. When we want to do a restore from storage A to storage
diff --git a/src/PVE/Storage/DirPlugin.pm b/src/PVE/Storage/DirPlugin.pm
index ae5d083..0f8776b 100644
--- a/src/PVE/Storage/DirPlugin.pm
+++ b/src/PVE/Storage/DirPlugin.pm
@@ -315,4 +315,14 @@ sub get_import_metadata {
     };
 }
 
+sub volume_support_qemu_snapshot {
+    my ($class, $storeid, $scfg, $volname) = @_;
+
+    my $format = ($class->parse_volname($volname))[6];
+    return if $format ne 'qcow2';
+
+    my $type = $scfg->{snapext} ? 'external' : 'internal';
+    return $type;
+}
+
 1;
diff --git a/src/PVE/Storage/LVMPlugin.pm b/src/PVE/Storage/LVMPlugin.pm
index ef010b8..3e3e48c 100644
--- a/src/PVE/Storage/LVMPlugin.pm
+++ b/src/PVE/Storage/LVMPlugin.pm
@@ -1199,4 +1199,11 @@ sub get_snap_volname {
     return $class->get_snap_name($volname, $snapname);
 }
 
+sub volume_support_qemu_snapshot {
+    my ($class, $storeid, $scfg, $volname) = @_;
+
+    my $format = ($class->parse_volname($volname))[6];
+    return 'external' if $format eq 'qcow2';
+}
+
 1;
diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm
index 68d17ff..bf190d2 100644
--- a/src/PVE/Storage/Plugin.pm
+++ b/src/PVE/Storage/Plugin.pm
@@ -2292,6 +2292,19 @@ sub qemu_blockdev_options {
     return $blockdev;
 }
 
+
+# Returns the method type to take a snapshot with qemu:
+# 'internal' : support snapshot with qemu internal snapshot
+# 'external' : support do the snapshot with qemu external snapshot
+# undef : don't support qemu snapshot
+
+sub volume_support_qemu_snapshot {
+    my ($class, $storeid, $scfg, $volname) = @_;
+
+    my $format = ($class->parse_volname($volname))[6];
+    return 'internal' if $format eq 'qcow2';
+}
+
 # Used by storage plugins for external backup providers. See PVE::BackupProvider::Plugin for the API
 # the provider needs to implement.
 #
diff --git a/src/PVE/Storage/RBDPlugin.pm b/src/PVE/Storage/RBDPlugin.pm
index 883b0e4..8065cfc 100644
--- a/src/PVE/Storage/RBDPlugin.pm
+++ b/src/PVE/Storage/RBDPlugin.pm
@@ -1057,4 +1057,10 @@ sub rename_volume {
     return "${storeid}:${base_name}${target_volname}";
 }
 
+sub volume_support_qemu_snapshot {
+    my ($class, $storeid, $scfg, $volname) = @_;
+
+    return 'internal' if !$scfg->{krbd};
+}
+
 1;
-- 
2.39.5



[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

  parent reply	other threads:[~2025-07-04  6:46 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20250704064507.511884-1-alexandre.derumier@groupe-cyllene.com>
2025-07-04  6:44 ` [pve-devel] [PATCH qemu-server 1/3] qemu_img convert : add external snapshot support Alexandre Derumier via pve-devel
2025-07-04  6:44 ` [pve-devel] [PATCH pve-storage 01/10] tests: add lvmplugin test Alexandre Derumier via pve-devel
2025-07-04  6:44 ` [pve-devel] [PATCH qemu-server 2/3] blockdev: add backing_chain support Alexandre Derumier via pve-devel
2025-07-04  6:44 ` [pve-devel] [PATCH pve-storage 02/10] common: add qemu_img_create an preallocation_cmd_option Alexandre Derumier via pve-devel
2025-07-04 11:53   ` Fabian Grünbichler
2025-07-04 12:33     ` DERUMIER, Alexandre via pve-devel
     [not found]     ` <51f988f11e60f9dfaa49658c1ed9ecf72fcfcde4.camel@groupe-cyllene.com>
2025-07-07  7:55       ` Fabian Grünbichler
2025-07-04  6:44 ` [pve-devel] [PATCH pve-storage 03/10] common: qemu_img_create: add backing_file support Alexandre Derumier via pve-devel
2025-07-04 11:52   ` Fabian Grünbichler
2025-07-04 12:31     ` DERUMIER, Alexandre via pve-devel
2025-07-07  7:16     ` DERUMIER, Alexandre via pve-devel
2025-07-04  6:45 ` [pve-devel] [PATCH qemu-server 3/3] qcow2: add external snapshot support Alexandre Derumier via pve-devel
2025-07-04 11:52   ` Fabian Grünbichler
2025-07-04 12:46     ` DERUMIER, Alexandre via pve-devel
2025-07-04  6:45 ` [pve-devel] [PATCH pve-storage 04/10] rename_volume: add source && target snap Alexandre Derumier via pve-devel
2025-07-04 11:52   ` Fabian Grünbichler
2025-07-04 12:04     ` Thomas Lamprecht
2025-07-07 10:34     ` DERUMIER, Alexandre via pve-devel
2025-07-04  6:45 ` [pve-devel] [PATCH pve-storage 05/10] common: add qemu_img_info helper Alexandre Derumier via pve-devel
2025-07-04  6:45 ` [pve-devel] [PATCH pve-storage 06/10] common: add qemu-img measure Alexandre Derumier via pve-devel
2025-07-04 11:51   ` Fabian Grünbichler
2025-07-04  6:45 ` [pve-devel] [PATCH pve-storage 07/10] storage: volume_snapshot: add $running param Alexandre Derumier via pve-devel
2025-07-04 11:52   ` Fabian Grünbichler
2025-07-04  6:45 ` [pve-devel] [PATCH pve-storage 08/10] qcow2: add external snapshot support Alexandre Derumier via pve-devel
2025-07-04 11:52   ` Fabian Grünbichler
2025-07-04 13:22     ` DERUMIER, Alexandre via pve-devel
     [not found]     ` <c38598bae6477dfa6af0db96da054b156698d41c.camel@groupe-cyllene.com>
2025-07-07  8:17       ` Fabian Grünbichler
2025-07-07 10:18         ` DERUMIER, Alexandre via pve-devel
     [not found]         ` <c671fe82a7cdab90a3691115a7132d0a35ae79b7.camel@groupe-cyllene.com>
2025-07-07 10:53           ` Fabian Grünbichler
2025-07-08  8:44     ` DERUMIER, Alexandre via pve-devel
     [not found]     ` <3d1d8516e3c68de370608033647a38e99ef50f23.camel@groupe-cyllene.com>
2025-07-08  8:56       ` Fabian Grünbichler
2025-07-08 11:37         ` DERUMIER, Alexandre via pve-devel
2025-07-08 10:04     ` DERUMIER, Alexandre via pve-devel
     [not found]     ` <27854af70a4fe3a7765d2760098e2f82f3475f17.camel@groupe-cyllene.com>
2025-07-08 10:59       ` Fabian Grünbichler
2025-07-08 11:35         ` DERUMIER, Alexandre via pve-devel
     [not found]         ` <0b2ba0c34d2c8c15d7cb642442b300a3180e1592.camel@groupe-cyllene.com>
2025-07-08 12:50           ` Thomas Lamprecht
2025-07-08 13:19             ` DERUMIER, Alexandre via pve-devel
2025-07-08 13:42         ` DERUMIER, Alexandre via pve-devel
     [not found]         ` <67627e7904281520e1f7152657ed00c7ba3c138b.camel@groupe-cyllene.com>
2025-07-08 14:18           ` Fabian Grünbichler
2025-07-09 12:52     ` DERUMIER, Alexandre via pve-devel
2025-07-04  6:45 ` [pve-devel] [PATCH pve-storage 09/10] lvmplugin: add qcow2 snapshot Alexandre Derumier via pve-devel
2025-07-04 11:51   ` Fabian Grünbichler
2025-07-09  7:24     ` DERUMIER, Alexandre via pve-devel
2025-07-09  8:06     ` DERUMIER, Alexandre via pve-devel
2025-07-04  6:45 ` Alexandre Derumier via pve-devel [this message]
2025-07-04 11:51   ` [pve-devel] [PATCH pve-storage 10/10] storage : add volume_support_qemu_snapshot Fabian Grünbichler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mailman.965.1751611555.395.pve-devel@lists.proxmox.com \
    --to=pve-devel@lists.proxmox.com \
    --cc=alexandre.derumier@groupe-cyllene.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal