Re: [pve-devel] [RFC qemu-server v2 32/32] command line: switch to blockdev starting with machine version 10.0 - DERUMIER, Alexandre via pve-devel

From: "DERUMIER, Alexandre via pve-devel" <pve-devel@lists.proxmox.com>
To: "pve-devel@lists.proxmox.com" <pve-devel@lists.proxmox.com>
Cc: "DERUMIER, Alexandre" <alexandre.derumier@groupe-cyllene.com>
Subject: Re: [pve-devel] [RFC qemu-server v2 32/32] command line: switch to blockdev starting with machine version 10.0
Date: Mon, 23 Jun 2025 09:12:43 +0000	[thread overview]
Message-ID: <mailman.507.1750669973.395.pve-devel@lists.proxmox.com> (raw)
In-Reply-To: <20250618130209.90649-33-f.ebner@proxmox.com>

[-- Attachment #1: Type: message/rfc822, Size: 12420 bytes --]

From: "DERUMIER, Alexandre" <alexandre.derumier@groupe-cyllene.com>
To: "pve-devel@lists.proxmox.com" <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [RFC qemu-server v2 32/32] command line: switch to blockdev starting with machine version 10.0
Date: Mon, 23 Jun 2025 09:12:43 +0000
Message-ID: <d105eff412538c94deb41c93a30c0018d9d015c5.camel@groupe-cyllene.com>

>>+        my $blockdev =
>>PVE::QemuServer::Blockdev::generate_drive_blockdev($storecfg,
>>$device, {});
>>+        mon_cmd($vmid, 'blockdev-add', %$blockdev, timeout => 60);
>>+
>>+        return 1;

should we handle error here ?  (I don't known if a blockdev-add can
fail , and if it need 60s timeout like drive-add, as I think that the
blockdev open is done in device-add)

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel