Re: [pve-devel] [PATCH-SERIES v6 pve-storage/qemu-server/pve-qemu] add external qcow2 snapshot support - joao.sousa via pve-devel

From: "joao.sousa via pve-devel" <pve-devel@lists.proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Cc: "joao.sousa" <joao.sousa@eurotux.com>
Subject: Re: [pve-devel] [PATCH-SERIES v6 pve-storage/qemu-server/pve-qemu] add external qcow2 snapshot support
Date: Wed, 11 Jun 2025 22:28:42 +0100	[thread overview]
Message-ID: <mailman.340.1749677335.395.pve-devel@lists.proxmox.com> (raw)
In-Reply-To: <a9684394-b9a0-4566-81ef-c7b8d44a859e@proxmox.com>

[-- Attachment #1: Type: message/rfc822, Size: 5964 bytes --]

From: "joao.sousa" <joao.sousa@eurotux.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH-SERIES v6 pve-storage/qemu-server/pve-qemu] add external qcow2 snapshot support
Date: Wed, 11 Jun 2025 22:28:42 +0100
Message-ID: <5sqpzsnyzmfvvoco3ilo6tg3pcpomhle7h5dsnmbsbdjobpr5a@rqfsbsas36e2>

On 10/06/25 10:54, Fiona Ebner wrote:
> What exactly is your goal with the feature? If you want to build
> something on top of it, it might be better to wait until it is
> finalized/applied. Currently, the most helpful contribution with the
> feature itself would be testing and reviewing Alexandre's changes. For
> testing, you'll need to apply the changes and build and install the
> affected packages. Reviewing requires getting familiar with the code
> base first.

For now, I want to help agile the process of getting the feature to a
stable state. Later on, I'd like to contribute to a version which
enables thin provisioned snapshots.

Regarding the testing, I am having a little bit of trouble applying the
current patches.

This is the output of git am when applying the qemu-server patches:

Applying: blockdev: cmdline: add blockdev syntax support
.git/rebase-apply/patch:972: trailing whitespace.
boot:
error: patch failed: test/cfg2cmd/simple-btrfs.conf.cmd:32
error: test/cfg2cmd/simple-btrfs.conf.cmd: patch does not apply
error: patch failed: test/cfg2cmd/simple-rbd.conf.cmd:34
error: test/cfg2cmd/simple-rbd.conf.cmd: patch does not apply
error: patch failed: test/cfg2cmd/simple-zfs-over-iscsi.conf.cmd:32
error: test/cfg2cmd/simple-zfs-over-iscsi.conf.cmd: patch does not apply
Patch failed at 0001 blockdev: cmdline: add blockdev syntax support
hint: Use 'git am --show-current-patch=diff' to see the failed patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

It also happens when applying the pve-storage patches. Am I missing something?

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel