Re: [pve-devel] [PATCH qemu-server 01/13] blockdev: cmdline: add blockdev syntax support - DERUMIER, Alexandre via pve-devel

From: "DERUMIER, Alexandre via pve-devel" <pve-devel@lists.proxmox.com>
To: "pve-devel@lists.proxmox.com" <pve-devel@lists.proxmox.com>,
	"f.ebner@proxmox.com" <f.ebner@proxmox.com>
Cc: "DERUMIER, Alexandre" <alexandre.derumier@groupe-cyllene.com>
Subject: Re: [pve-devel] [PATCH qemu-server 01/13] blockdev: cmdline: add blockdev syntax support
Date: Wed, 11 Jun 2025 14:02:27 +0000	[thread overview]
Message-ID: <mailman.333.1749650558.395.pve-devel@lists.proxmox.com> (raw)
In-Reply-To: <89f35782-849e-4099-8874-6b035897982c@proxmox.com>

[-- Attachment #1: Type: message/rfc822, Size: 14087 bytes --]

From: "DERUMIER, Alexandre" <alexandre.derumier@groupe-cyllene.com>
To: "pve-devel@lists.proxmox.com" <pve-devel@lists.proxmox.com>, "f.ebner@proxmox.com" <f.ebner@proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu-server 01/13] blockdev: cmdline: add blockdev syntax support
Date: Wed, 11 Jun 2025 14:02:27 +0000
Message-ID: <733f5eefb25b76a0794a84d4f93ada8d70aea7be.camel@groupe-cyllene.com>

> >
> >>
> >I still unsure how to handle same volume multiple time (if we really
> >want it). I was thinking to use the deviceid in the name
> >(virtio0,..),
> >but it don't work when you unplug/replug to a deviceid.

>>Why wouldn't it work?

Ah sorry, I forgot that we delete the blocknode on unplug.

so it should work indeed

> Maybe some kind of slot number like fabian have suggested, but I
> think
> it'll need  some kind of lookup.
> 
> or maybe, if we want same volume multiple volume, we just keep
> autogenerated qemu blockdev for this specific case, as anyway, we
> can't
> do snapshot, unplug, or other dynamic features.

>>My proposal is:
>>
>>my sub get_node_name {
>>    my ($type, $drive_id, $volid, $snap) = @_;
>>
>>    my $info = "drive=$drive_id,";
>>    $info .= "snap=$snap," if defined($snap);
>>    $info .= "volid=$volid";
>>
>>    my $encoded = substr(Digest::SHA::sha256_hex($info), 0, 30);
>>
>>    my $prefix = "";
>>    if ($type eq 'fmt') {
>>       $prefix = 'f';
>>    } elsif ($type eq 'file') {
>>       $prefix = 'e';
>>    } else {
>>       die "unknown node type '$type'";
>>    }
>>    # node-name must start with an alphabetical character
>>    return "${prefix}${encoded}";
>>}

Ok !

I'm going to test it like this

(I'll be busy with proxmox training tomorrow && friday, so I'll rework
on it next week)

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel