Re: [pve-devel] [PATCH pve-storage 08/10] qcow2: add external snapshot support - DERUMIER, Alexandre via pve-devel

From: "DERUMIER, Alexandre via pve-devel" <pve-devel@lists.proxmox.com>
To: "pve-devel@lists.proxmox.com" <pve-devel@lists.proxmox.com>,
	"f.gruenbichler@proxmox.com" <f.gruenbichler@proxmox.com>
Cc: "DERUMIER, Alexandre" <alexandre.derumier@groupe-cyllene.com>
Subject: Re: [pve-devel] [PATCH pve-storage 08/10] qcow2: add external snapshot support
Date: Wed, 9 Jul 2025 12:52:44 +0000	[thread overview]
Message-ID: <mailman.1205.1752065605.395.pve-devel@lists.proxmox.com> (raw)
In-Reply-To: <2064112819.2237.1751629966392@webmail.proxmox.com>

[-- Attachment #1: Type: message/rfc822, Size: 12570 bytes --]

From: "DERUMIER, Alexandre" <alexandre.derumier@groupe-cyllene.com>
To: "pve-devel@lists.proxmox.com" <pve-devel@lists.proxmox.com>, "f.gruenbichler@proxmox.com" <f.gruenbichler@proxmox.com>
Subject: Re: [pve-devel] [PATCH pve-storage 08/10] qcow2: add external snapshot support
Date: Wed, 9 Jul 2025 12:52:44 +0000
Message-ID: <5640e9be14bbc97cc21edfa77fcc27c7305834d5.camel@groupe-cyllene.com>

> +sub get_snap_name {

>>should this be public?

I'll make it private

> +sub get_snap_volname {

>>should this be public?
> +
> +sub parse_snapname {

>>should this be public?

This two methods are used in volume_snapshot_info(), defined in plugin,
and use by lvmplugin too. (but the parsing is different in lvm plugin,
so the parse_snapname && get_snap_volname need to be public)

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel