From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Daniel Kral <d.kral@proxmox.com>
Subject: Re: [pve-devel] [RFC container v2 2/3] setup: base: remove existing ssh host keys
Date: Thu, 17 Jul 2025 02:27:04 +0200 [thread overview]
Message-ID: <d3f81da2-1671-4b97-ba3a-6cd5e0ccb134@proxmox.com> (raw)
In-Reply-To: <20250704182336.469274-2-d.kral@proxmox.com>
Am 04.07.25 um 20:23 schrieb Daniel Kral:
> Remove existing SSH host keys after container creation to prevent
> multiple containers sharing the same SSH host keys, especially those
> which are not overwritten/generated by rewrite_ssh_host_keys() later.
>
> This is called in the Base's post_create_hook(...) to prevent unwanted
> removal for certain types of containers, e.g., unmanaged containers.
>
Does this also remove host keys on backup restore? If, this is probably
a bit to intrusive. For clone/restore we might couple it with the "unique"
flag, just as an (not so thought out) idea.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-07-17 0:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-04 18:23 [pve-devel] [PATCH container v2 1/3] setup: remove deprecated dsa from ssh host key generation Daniel Kral
2025-07-04 18:23 ` [pve-devel] [RFC container v2 2/3] setup: base: remove existing ssh host keys Daniel Kral
2025-07-17 0:27 ` Thomas Lamprecht [this message]
2025-07-04 18:23 ` [pve-devel] [RFC container v2 3/3] setup: skip rewriting ignored " Daniel Kral
2025-07-16 11:36 ` [pve-devel] [PATCH container v2 1/3] setup: remove deprecated dsa from ssh host key generation Lukas Wagner
2025-07-16 12:07 ` Lukas Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3f81da2-1671-4b97-ba3a-6cd5e0ccb134@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.kral@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.