Re: [pve-devel] [PATCH v3 storage 6/9] rbd plugin: implement new method to get qemu blockdevice options

From: Fiona Ebner <f.ebner@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
	"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: Re: [pve-devel] [PATCH v3 storage 6/9] rbd plugin: implement new method to get qemu blockdevice options
Date: Tue, 1 Jul 2025 14:15:14 +0200	[thread overview]
Message-ID: <b9058df0-a1ac-47fc-97c2-5db85c11c71b@proxmox.com> (raw)
In-Reply-To: <1751282340.4gscq50eyh.astroid@yuna.none>

Am 30.06.25 um 13:19 schrieb Fabian Grünbichler:
> On June 26, 2025 4:40 pm, Fiona Ebner wrote:
>> The mon host parsing is adapted from other places. While there
>> currently is no support for vector notation in the storage config
>> (it's a pve-storage-portal-dns-list option), it doesn't hurt to
>> anticipate it, should the list of mon hosts come from a ceph.conf
>> instead anytime in the future.
> 
> but in `path` we don't do this? shouldn't this be consistent?

Okay, I'll drop it in v4.

> also, we already have a full helper for getting a mon list from a ceph
> config, so if we ever use that as source here, shouldn't we use that
> helper?

Would need to be adapted a bit (to avoid joining+splitting), but sure.

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel