all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Gabriel Goller <g.goller@proxmox.com>
To: Wolfgang Bumiller <w.bumiller@proxmox.com>
Cc: pdm-devel@lists.proxmox.com
Subject: Re: [pdm-devel] [PATCH proxmox 2/3] section-config: remove DerefMut and make underlying HashMap private
Date: Wed, 23 Apr 2025 11:40:16 +0200	[thread overview]
Message-ID: <zx2hepix3b4obc2xmcmu4xszswbrkw3doqwpeqxono5d35tjbi@yrk64bqut2bf> (raw)
In-Reply-To: <rkrv5u6dcpwgwu7vqrlttrrntwp3c7jwqvdv4adcovtxpwkczb@rqw3suoyoqoz>

On 15.04.2025 10:29, Wolfgang Bumiller wrote:
>1 minor thing...
>
>On Mon, Apr 14, 2025 at 02:00:44PM +0200, Gabriel Goller wrote:
>> [snip]
>> +    /// Remove a key-value pair from the section config.
>> +    ///
>> +    /// If the key existed and was removed, also remove the key from the order vector
>> +    /// to maintain ordering consistency.
>> +    ///
>> +    /// # Returns
>> +    ///
>> +    /// * `Some(value)` - If the key was present, returns the value that was removed
>> +    /// * `None` - If the key was not present
>> +    pub fn remove(&mut self, key: &str) -> Option<T> {
>> +        let removed_value = self.sections.remove(key);
>> +        // only update the order vector if we actually removed something
>> +        if removed_value.is_some() {
>> +            self.order.retain(|k| k != key);
>
>`retain()` always goes through the entire vector. We don't typically
>have large numbers of sections, so, not that bad, butin general I do
>lean more towards
>
>    if let Some(pos) = vec.iter().position(|k| k == key) {
>        vec.remove(pos);
>    }
>
>when we know there should only be at most 1 such element

Yup, we can guarantee that AFAIK.

Fixed it.


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


  reply	other threads:[~2025-04-23  9:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-14 12:00 [pdm-devel] [PATCH proxmox{, -datacenter-manager} 0/4] Remove direct access to SectionConfigData<T> sections Gabriel Goller
2025-04-14 12:00 ` [pdm-devel] [PATCH proxmox 1/3] section-config: make write_section_config parameter more generic Gabriel Goller
2025-04-15  6:44   ` Wolfgang Bumiller
2025-04-23  9:35     ` Gabriel Goller
2025-04-14 12:00 ` [pdm-devel] [PATCH proxmox 2/3] section-config: remove DerefMut and make underlying HashMap private Gabriel Goller
2025-04-15  8:29   ` Wolfgang Bumiller
2025-04-23  9:40     ` Gabriel Goller [this message]
2025-04-15  8:42   ` Wolfgang Bumiller
2025-04-23  9:44     ` Gabriel Goller
2025-04-14 12:00 ` [pdm-devel] [PATCH proxmox 3/3] section-config: add lookup and convert_to_typed_array helpers Gabriel Goller
2025-04-15  8:39   ` Wolfgang Bumiller
2025-04-23 10:00     ` Gabriel Goller
2025-04-14 12:00 ` [pdm-devel] [PATCH proxmox-datacenter-manager 1/1] remotes: remove direct access on underlying sections HashMap Gabriel Goller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=zx2hepix3b4obc2xmcmu4xszswbrkw3doqwpeqxono5d35tjbi@yrk64bqut2bf \
    --to=g.goller@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    --cc=w.bumiller@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal