all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH v2 pve-esxi-import-tools 0/7] Improve listvms.py
@ 2024-03-22 18:06 Max Carrara
  2024-03-22 18:06 ` [pve-devel] [PATCH v2 pve-esxi-import-tools 1/7] listvms: remove unused import and variable Max Carrara
                   ` (7 more replies)
  0 siblings, 8 replies; 9+ messages in thread
From: Max Carrara @ 2024-03-22 18:06 UTC (permalink / raw)
  To: pve-devel

Improve listvms.py - Version 2
==============================

Notable Changes Since v1
------------------------

* mypy [0] is now a build dependency and runs automatically on
  `make install` (and thus also on `make deb` etc.)
* JSON output is now directly streamed to stdout via `json.dump()`
  instead of creating and printing a string

For a detailed list of changes, please see the comments in the
invididual patches.

Older Versions
--------------

v1: https://lists.proxmox.com/pipermail/pve-devel/2024-March/062258.html

References
----------

[0]: https://www.mypy-lang.org/

Summary of Changes
------------------

Max Carrara (7):
  listvms: remove unused import and variable
  listvms: reorder imports
  listvms: improve typing and add dataclasses to represent dicts
  listvms: add arg parser, context manager for connections, fetch helper
  listvms: dump json directly to stdout
  listvms: run formatter
  use mypy for automatic type checks in Python

 Makefile       |  13 ++-
 debian/control |   1 +
 listvms.py     | 300 +++++++++++++++++++++++++++++++++++++------------
 mypy.ini       |   8 ++
 4 files changed, 247 insertions(+), 75 deletions(-)
 create mode 100644 mypy.ini

-- 
2.39.2





^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2024-03-27 10:50 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-22 18:06 [pve-devel] [PATCH v2 pve-esxi-import-tools 0/7] Improve listvms.py Max Carrara
2024-03-22 18:06 ` [pve-devel] [PATCH v2 pve-esxi-import-tools 1/7] listvms: remove unused import and variable Max Carrara
2024-03-22 18:06 ` [pve-devel] [PATCH v2 pve-esxi-import-tools 2/7] listvms: reorder imports Max Carrara
2024-03-22 18:06 ` [pve-devel] [PATCH v2 pve-esxi-import-tools 3/7] listvms: improve typing and add dataclasses to represent dicts Max Carrara
2024-03-22 18:06 ` [pve-devel] [PATCH v2 pve-esxi-import-tools 4/7] listvms: add arg parser, context manager for connections, fetch helper Max Carrara
2024-03-22 18:06 ` [pve-devel] [PATCH v2 pve-esxi-import-tools 5/7] listvms: dump json directly to stdout Max Carrara
2024-03-22 18:06 ` [pve-devel] [PATCH v2 pve-esxi-import-tools 6/7] listvms: run formatter Max Carrara
2024-03-22 18:06 ` [pve-devel] [PATCH v2 pve-esxi-import-tools 7/7] use mypy for automatic type checks in Python Max Carrara
2024-03-27 10:50 ` [pve-devel] applied-series: [PATCH v2 pve-esxi-import-tools 0/7] Improve listvms.py Wolfgang Bumiller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal