Re: [pdm-devel] [PATCH datacenter-manager] ui: dashboard: drop s3 and removable stores from PBS datastore panel

[Wolfgang Bumiller <w.bumiller@proxmox.com>]

On Wed, Oct 29, 2025 at 11:09:58AM +0100, Christian Ebner wrote:
> The PBS datastore panel currently mixes status information
> (maintenance, usage, ...) with datastore properties (removable, s3).
> Since the latter will not change, and the dashboard panels are more
> intended to show current status information, drop the removable and
> s3 columns. The search filters remain unaffected by this, still
> allowing to filter PBS datastored by these.

Is there another place where we already see this? Or is something
planned?
I'm just wondering where else this would make sense.

> 
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---
>  ui/src/dashboard/pbs_datastores_panel.rs | 16 ----------------
>  1 file changed, 16 deletions(-)
> 
> diff --git a/ui/src/dashboard/pbs_datastores_panel.rs b/ui/src/dashboard/pbs_datastores_panel.rs
> index 3e148e6..a06acf7 100644
> --- a/ui/src/dashboard/pbs_datastores_panel.rs
> +++ b/ui/src/dashboard/pbs_datastores_panel.rs
> @@ -40,8 +40,6 @@ impl From<PbsDatastoresPanel> for VNode {
>  pub enum StatusRow {
>      Online(u64),
>      UnderMaintenance(u64),
> -    Removable(u64),
> -    S3Backend(u64),
>      HighUsage(u64),
>      Unknown(u64),
>      All(u64),
> @@ -75,8 +73,6 @@ impl yew::Component for PbsDatastoresPanelComponent {
>          let data = vec![
>              StatusRow::Online(status.online),
>              StatusRow::UnderMaintenance(status.under_maintenance.unwrap_or_default()),
> -            StatusRow::Removable(status.removable.unwrap_or_default()),
> -            StatusRow::S3Backend(status.s3_backend.unwrap_or_default()),
>              StatusRow::HighUsage(status.high_usage.unwrap_or_default()),
>              StatusRow::Unknown(status.unknown.unwrap_or_default()),
>              StatusRow::All(status.online + status.under_maintenance.unwrap_or_default()),
> @@ -121,18 +117,6 @@ fn create_list_tile(
>              "Under Maintenance",
>              Some(("under-maintenance", "status")),
>          ),
> -        StatusRow::Removable(count) => (
> -            Fa::new("plug"),
> -            count,
> -            "Removable",
> -            Some(("removable", "property")),
> -        ),
> -        StatusRow::S3Backend(count) => (
> -            Fa::new("cloud-upload"),
> -            count,
> -            "S3",
> -            Some(("s3", "property")),
> -        ),
>          StatusRow::Unknown(count) => (
>              Fa::from(Status::Unknown),
>              count,
> -- 
> 2.47.3


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel