From: Gabriel Goller <g.goller@proxmox.com>
To: Wolfgang Bumiller <w.bumiller@proxmox.com>
Cc: pbs-devel@lists.proxmox.com
Subject: Re: [pbs-devel] [PATCH proxmox-backup] cargo: add pbs-api-types override and reorder overrides
Date: Thu, 20 Feb 2025 16:52:32 +0100 [thread overview]
Message-ID: <ywi73vnzncue7wc2pgtkwz75p6em6iehnwfifvrvmnlnl7ye5t@exdemxhzkp4v> (raw)
In-Reply-To: <jkqhjqe7rwexrbe3dyo3k7t26bjvyvscvqavhk7krxynhlbtev@euakwohmho5i>
On 20.02.2025 16:35, Wolfgang Bumiller wrote:
>On Thu, Feb 20, 2025 at 04:31:36PM +0100, Gabriel Goller wrote:
>> Add the new pbs-api-types crate to the cargo override section. Reorder
>> the overrides to be alphabetic.
>>
>> Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
>> ---
>> Cargo.toml | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/Cargo.toml b/Cargo.toml
>> index 062de7cfb989..427e3e2d57e8 100644
>> --- a/Cargo.toml
>> +++ b/Cargo.toml
>> @@ -253,7 +253,7 @@ proxmox-rrd-api-types.workspace = true
>> # Local path overrides
>> # NOTE: You must run `cargo update` after changing this for it to take effect!
>> [patch.crates-io]
>> -
>> +#proxmox-acme = { path = "../proxmox/proxmox-acme" }
>> #proxmox-apt = { path = "../proxmox/proxmox-apt" }
>> #proxmox-apt-api-types = { path = "../proxmox/proxmox-apt-api-types" }
>> #proxmox-async = { path = "../proxmox/proxmox-async" }
>> @@ -289,8 +289,8 @@ proxmox-rrd-api-types.workspace = true
>> #proxmox-uuid = { path = "../proxmox/proxmox-uuid" }
>> #proxmox-worker-task = { path = "../proxmox/proxmox-worker-task" }
>>
>> -#proxmox-acme = { path = "../proxmox/proxmox-acme" }
>> #pathpatterns = {path = "../pathpatterns" }
>> +#pbs-api-types = { path = "../proxmox/pbs-api-types" }
>
>While the name looks different, given that overrides need to be enabled
>as complete workspaces I'd argue this line should be in the proxmox.git
>block above.
Ok, submitted a v2!
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2025-02-20 15:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-20 15:31 Gabriel Goller
2025-02-20 15:35 ` Wolfgang Bumiller
2025-02-20 15:52 ` Gabriel Goller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ywi73vnzncue7wc2pgtkwz75p6em6iehnwfifvrvmnlnl7ye5t@exdemxhzkp4v \
--to=g.goller@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=w.bumiller@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.