Re: [RFC proxmox 04/22] firewall-api-types: add logging types

[Wolfgang Bumiller <w.bumiller@proxmox.com>]

On Thu, Mar 05, 2026 at 08:04:09AM +0100, Dietmar Maurer wrote:
> > > +serde_plain::derive_deserialize_from_fromstr!(FirewallPacketRate, "valid packet rate");
> > > +serde_plain::derive_serialize_from_display!(FirewallPacketRate);
> > we have similar macros in proxmox-serde as well [1]. Would potentially
> > save an external dependency? applies to all instances in this patch
> > series ofc.
> I think we should remove those macros, and use serde_plain instead.

Did not see this before my other reply. Either way the tests don't need
it (and are weird regardless).

Anyway, they are quite cheap and serde has gained a lot more building
blocks to one-line the implementations which in serde_plain are a lot
bigger.

Also, we probably won't drop `proxmox-serde`, while we did already have
other competing alternatives such as `serde-with` in our repos.
These macros are quite primitive and should be actually be part of
`serde` itself, but unfortunately they aren't :(