Re: [pve-devel] [PATCH installer 0/4] assistant: clean up glob patterns & regexes

[Christoph Heiss <c.heiss@proxmox.com>]

On Mon, May 13, 2024 at 11:18:51AM +0200, Aaron Lauterer wrote:
> it seems these patches don't apply anymore. could you please do a rebase on
> current master?

Sure, thanks for the notice!
Seems 1a01a01 ("assistant: keep prepared iso bootable on uefi with flash drives")
"broke" it, due to an import statement change :')

v2: https://lists.proxmox.com/pipermail/pve-devel/2024-May/063833.html

>
> On  2024-05-07  15:21, Christoph Heiss wrote:
> > The proxmox-auto-install-assistant uses
> >    - glob patterns for disk matching, which can be pre-compiled for
> >      efficiency
> >    - regexes for udev property matching, which can be simplified by some
> >      simple prefix matching & splitting on =
> >
> > The latter also significantly reduces binary size due to the removing
> > the regex dependency, for details see patch #4.
> >
> > Overall no functional changes in this series.
> >
> > Christoph Heiss (4):
> >    tree-wide: run rustfmt, fix clippy warnings
> >    assistant: drop unused `log` dependency
> >    assistant: pre-compile ignored block device patterns
> >    assistant: avoid regex for simple prefix matching
> >
> >   proxmox-auto-install-assistant/Cargo.toml     |  2 -
> >   proxmox-auto-install-assistant/src/main.rs    | 75 ++++++++-----------
> >   proxmox-auto-installer/tests/parse-answer.rs  | 14 ++--
> >   .../src/fetch_plugins/partition.rs            | 10 +--
> >   4 files changed, 45 insertions(+), 56 deletions(-)
> >
> > --
> > 2.44.0
> >
> >
> >
> > _______________________________________________
> > pve-devel mailing list
> > pve-devel@lists.proxmox.com
> > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> >
> >


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel