* [pve-devel] [PATCH pmg-docs] installation: fix codeblock rendering in zfs performance tips section
@ 2024-02-28 18:08 Christoph Heiss
2024-02-28 19:03 ` [pve-devel] applied: " Stoiko Ivanov
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Heiss @ 2024-02-28 18:08 UTC (permalink / raw)
To: pve-devel
That slipped through, asciidoc uses 4 not 3 dashes for that.
Fixes: c8be3f0 ("installation: align zfs performance tip with PVE documentation")
Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
---
pmg-installation.adoc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/pmg-installation.adoc b/pmg-installation.adoc
index 326fe5b..25d16a7 100644
--- a/pmg-installation.adoc
+++ b/pmg-installation.adoc
@@ -284,9 +284,9 @@ ZFS can use a dedicated drive as write cache, called the ZFS Intent Log (ZIL).
Use a fast drive (SSD) for it. It can be added after installation with the
following command:
----
+----
# zpool add <pool-name> log </dev/path_to_fast_ssd>
----
+----
Adding the `nomodeset` Kernel Parameter
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
--
2.43.0
^ permalink raw reply [flat|nested] 3+ messages in thread* [pve-devel] applied: [PATCH pmg-docs] installation: fix codeblock rendering in zfs performance tips section
2024-02-28 18:08 [pve-devel] [PATCH pmg-docs] installation: fix codeblock rendering in zfs performance tips section Christoph Heiss
@ 2024-02-28 19:03 ` Stoiko Ivanov
2024-02-29 9:05 ` Christoph Heiss
0 siblings, 1 reply; 3+ messages in thread
From: Stoiko Ivanov @ 2024-02-28 19:03 UTC (permalink / raw)
To: Christoph Heiss; +Cc: Proxmox VE development discussion
Thanks for the catch and fix! applied it!
(nit: pmg-devel@list.proxmox.com is preferred for pmg-docs patches)
On Wed, 28 Feb 2024 19:08:21 +0100
Christoph Heiss <c.heiss@proxmox.com> wrote:
> That slipped through, asciidoc uses 4 not 3 dashes for that.
>
> Fixes: c8be3f0 ("installation: align zfs performance tip with PVE documentation")
> Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
> ---
> pmg-installation.adoc | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/pmg-installation.adoc b/pmg-installation.adoc
> index 326fe5b..25d16a7 100644
> --- a/pmg-installation.adoc
> +++ b/pmg-installation.adoc
> @@ -284,9 +284,9 @@ ZFS can use a dedicated drive as write cache, called the ZFS Intent Log (ZIL).
> Use a fast drive (SSD) for it. It can be added after installation with the
> following command:
>
> ----
> +----
> # zpool add <pool-name> log </dev/path_to_fast_ssd>
> ----
> +----
>
> Adding the `nomodeset` Kernel Parameter
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [pve-devel] applied: [PATCH pmg-docs] installation: fix codeblock rendering in zfs performance tips section
2024-02-28 19:03 ` [pve-devel] applied: " Stoiko Ivanov
@ 2024-02-29 9:05 ` Christoph Heiss
0 siblings, 0 replies; 3+ messages in thread
From: Christoph Heiss @ 2024-02-29 9:05 UTC (permalink / raw)
To: Stoiko Ivanov; +Cc: Proxmox VE development discussion
On Wed, Feb 28, 2024 at 08:03:08PM +0100, Stoiko Ivanov wrote:
> Thanks for the catch and fix! applied it!
Thanks!
>
> (nit: pmg-devel@list.proxmox.com is preferred for pmg-docs patches)
Saw it unfortunately only when it was already to late - sorry for the
noise!
>
> On Wed, 28 Feb 2024 19:08:21 +0100
> Christoph Heiss <c.heiss@proxmox.com> wrote:
>
> > That slipped through, asciidoc uses 4 not 3 dashes for that.
> >
> > Fixes: c8be3f0 ("installation: align zfs performance tip with PVE documentation")
> > Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
> > ---
> > pmg-installation.adoc | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/pmg-installation.adoc b/pmg-installation.adoc
> > index 326fe5b..25d16a7 100644
> > --- a/pmg-installation.adoc
> > +++ b/pmg-installation.adoc
> > @@ -284,9 +284,9 @@ ZFS can use a dedicated drive as write cache, called the ZFS Intent Log (ZIL).
> > Use a fast drive (SSD) for it. It can be added after installation with the
> > following command:
> >
> > ----
> > +----
> > # zpool add <pool-name> log </dev/path_to_fast_ssd>
> > ----
> > +----
> >
> > Adding the `nomodeset` Kernel Parameter
> > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-29 9:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-28 18:08 [pve-devel] [PATCH pmg-docs] installation: fix codeblock rendering in zfs performance tips section Christoph Heiss
2024-02-28 19:03 ` [pve-devel] applied: " Stoiko Ivanov
2024-02-29 9:05 ` Christoph Heiss
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.