From: Christoph Heiss <c.heiss@proxmox.com>
To: Stoiko Ivanov <s.ivanov@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] applied: [PATCH pmg-docs] installation: fix codeblock rendering in zfs performance tips section
Date: Thu, 29 Feb 2024 10:05:12 +0100 [thread overview]
Message-ID: <x2q7zkjka5ogdamxvvp3lv3mjyftespucravzkfbosy6z27sft@o3lu3fi7ymbu> (raw)
In-Reply-To: <20240228200308.4a2f8c35@rosa.proxmox.com>
On Wed, Feb 28, 2024 at 08:03:08PM +0100, Stoiko Ivanov wrote:
> Thanks for the catch and fix! applied it!
Thanks!
>
> (nit: pmg-devel@list.proxmox.com is preferred for pmg-docs patches)
Saw it unfortunately only when it was already to late - sorry for the
noise!
>
> On Wed, 28 Feb 2024 19:08:21 +0100
> Christoph Heiss <c.heiss@proxmox.com> wrote:
>
> > That slipped through, asciidoc uses 4 not 3 dashes for that.
> >
> > Fixes: c8be3f0 ("installation: align zfs performance tip with PVE documentation")
> > Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
> > ---
> > pmg-installation.adoc | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/pmg-installation.adoc b/pmg-installation.adoc
> > index 326fe5b..25d16a7 100644
> > --- a/pmg-installation.adoc
> > +++ b/pmg-installation.adoc
> > @@ -284,9 +284,9 @@ ZFS can use a dedicated drive as write cache, called the ZFS Intent Log (ZIL).
> > Use a fast drive (SSD) for it. It can be added after installation with the
> > following command:
> >
> > ----
> > +----
> > # zpool add <pool-name> log </dev/path_to_fast_ssd>
> > ----
> > +----
> >
> > Adding the `nomodeset` Kernel Parameter
> > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
prev parent reply other threads:[~2024-02-29 9:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-28 18:08 [pve-devel] " Christoph Heiss
2024-02-28 19:03 ` [pve-devel] applied: " Stoiko Ivanov
2024-02-29 9:05 ` Christoph Heiss [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x2q7zkjka5ogdamxvvp3lv3mjyftespucravzkfbosy6z27sft@o3lu3fi7ymbu \
--to=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.ivanov@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.