* [pve-devel] [PATCH pve-xtermjs] termproxy: fix the command line help text
@ 2024-07-24 11:32 Dietmar Maurer
2024-07-25 8:58 ` [pve-devel] applied: " Wolfgang Bumiller
0 siblings, 1 reply; 3+ messages in thread
From: Dietmar Maurer @ 2024-07-24 11:32 UTC (permalink / raw)
To: pve-devel
The <listen-port> need to be the first argument.
Signed-off-by: Dietmar Maurer <dietmar@proxmox.com>
---
termproxy/src/cli.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/termproxy/src/cli.rs b/termproxy/src/cli.rs
index cc44655..adfd830 100644
--- a/termproxy/src/cli.rs
+++ b/termproxy/src/cli.rs
@@ -4,7 +4,7 @@ use std::os::fd::RawFd;
use anyhow::{bail, Result};
const CMD_HELP: &str = "\
-Usage: proxmox-termproxy [OPTIONS] --path <path> <listen-port> -- <terminal-cmd>...
+Usage: proxmox-termproxy <listen-port> [OPTIONS] --path <path> -- <terminal-cmd>...
Arguments:
<listen-port> Port or file descriptor to listen for TCP connections
--
2.39.2
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* [pve-devel] applied: [PATCH pve-xtermjs] termproxy: fix the command line help text
2024-07-24 11:32 [pve-devel] [PATCH pve-xtermjs] termproxy: fix the command line help text Dietmar Maurer
@ 2024-07-25 8:58 ` Wolfgang Bumiller
2024-07-25 16:16 ` Thomas Lamprecht
0 siblings, 1 reply; 3+ messages in thread
From: Wolfgang Bumiller @ 2024-07-25 8:58 UTC (permalink / raw)
To: Dietmar Maurer; +Cc: pve-devel
applied, thanks
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [pve-devel] applied: [PATCH pve-xtermjs] termproxy: fix the command line help text
2024-07-25 8:58 ` [pve-devel] applied: " Wolfgang Bumiller
@ 2024-07-25 16:16 ` Thomas Lamprecht
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Lamprecht @ 2024-07-25 16:16 UTC (permalink / raw)
To: Proxmox VE development discussion, Wolfgang Bumiller, Dietmar Maurer
On 25/07/2024 10:58, Wolfgang Bumiller wrote:
> applied, thanks
>
this was a good stop-gap but as it wasn't much work I followed this up with
fixing the implementation. As while it's just a internal tool, it's still
nicer to have it behave as all CLI tools:
https://git.proxmox.com/?p=pve-xtermjs.git;a=commitdiff;h=4b8568cb4ff20a87bf2859bb0eb63c5afd3831d7;hp=69400e983e949a4f1a307a755b02af5fcd3efe65
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-07-25 16:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-07-24 11:32 [pve-devel] [PATCH pve-xtermjs] termproxy: fix the command line help text Dietmar Maurer
2024-07-25 8:58 ` [pve-devel] applied: " Wolfgang Bumiller
2024-07-25 16:16 ` Thomas Lamprecht
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.