Re: [PATCH pve-cluster 1/1] notifications: Add refresh_targets subroutine to PVE::Notify

[Arthur Bied-Charreton <a.bied-charreton@proxmox.com>]

On Mon, Mar 23, 2026 at 01:26:34PM +0100, Lukas Wagner wrote:
> On Fri Feb 13, 2026 at 5:04 PM CET, Arthur Bied-Charreton wrote:
> > Expose API to allow refreshing all notification targets' state from the
> > PVE backend, as well as from pveupdate.
> >
> > Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
> > ---
> >  src/PVE/Notify.pm | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git a/src/PVE/Notify.pm b/src/PVE/Notify.pm
> > index b44b5b3..ebb2311 100644
> > --- a/src/PVE/Notify.pm
> > +++ b/src/PVE/Notify.pm
> > @@ -103,6 +103,12 @@ sub error {
> >      );
> >  }
> >  
> > +sub trigger_state_refresh {
> > +    my ($config) = @_;
> > +    $config = read_config() if !defined($config);
> > +    $config->trigger_state_refresh();
> > +}
> > +
> 
> maybe I'm missing something, but it does not seem like you actually
> need/use this function?
>
No, this is a remnant of a different approach I took in the beginning,
sorry about that - will be gone in v2
> As far as I could tell you always call into the perlmod-bidings directly
> in the API handler as well as `pveupdate` and do not call this wrapper
> here?
> 
> Calling this helper here would be a 
> 
> PVE::Notify::trigger_state_refresh();
> 
> but you always do a 
> 
> my $config = PVE::Notify::read_config();
> $config->trigger_state_refresh();
> 
> 
> I think both variants would be OK, but you should either remove this
> patch here or actually use it at the call sites :)
>